Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(775)

Unified Diff: components/gcm_driver/gcm_stats_recorder_android.cc

Issue 2367373002: Track the ratio of received GCM messages for registered applications (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/gcm_driver/gcm_stats_recorder_android.cc
diff --git a/components/gcm_driver/gcm_stats_recorder_android.cc b/components/gcm_driver/gcm_stats_recorder_android.cc
index b07235cc37ad8d96501d79b06f0ce0aab1f5f161..5f89f2bcd23e68ad0e836b9044f6dcd4a74f86e9 100644
--- a/components/gcm_driver/gcm_stats_recorder_android.cc
+++ b/components/gcm_driver/gcm_stats_recorder_android.cc
@@ -106,6 +106,10 @@ void GCMStatsRecorderAndroid::RecordDataMessageReceived(
const std::string& app_id,
const std::string& from,
int message_byte_size) {
+ // Active registrations are maintained by Android, not Chrome, so any
+ // received data message is per definition still registered.
+ UMA_HISTOGRAM_BOOLEAN("GCM.DataMessageReceivedHasRegisteredApp", true);
johnme 2016/09/26 13:29:13 I'd lean towards not logging this - it feels misle
Peter Beverloo 2016/09/26 13:31:42 Done.
+
if (!is_recording_)
return;
« no previous file with comments | « no previous file | components/gcm_driver/gcm_stats_recorder_impl.cc » ('j') | tools/metrics/histograms/histograms.xml » ('J')

Powered by Google App Engine
This is Rietveld 408576698