Changed EEmptyCells to an enum class and renamed its members to keywords

Changed EEmptyCells to an enum class and renamed its members to keywords

Changed EEmptyCells to an enum class and gave it an unsigned underlying
type. Also renamed its members to match its keywords from
CSSValueKeywords.in. This is pre-work to move EEmptyCells to be
generated in ComputedStyleBase.

BUG=628043
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/058937513b328bdf63adfec95f0bfa8cc2c25f99
Cr-Commit-Position: refs/heads/master@{#422106}

[sashab, 2016-09-26 05:25:46]

Description was changed from

==========
Changed EEmptyCells to an enum class and renamed its members to keywords

Changed EEmptyCells to an enum class and gave it an unsigned underlying
type. Also renamed its members to match its keywords from
CSSValueKeywords.in. This is pre-work to move EEmptyCells to be
generated in ComputedStyleBase.

BUG=628043
==========

to

==========
Changed EEmptyCells to an enum class and renamed its members to keywords

Changed EEmptyCells to an enum class and gave it an unsigned underlying
type. Also renamed its members to match its keywords from
CSSValueKeywords.in. This is pre-work to move EEmptyCells to be
generated in ComputedStyleBase.

BUG=628043
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[sashab, 2016-09-26 05:26:00]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 05:26:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sashab, 2016-09-26 05:38:42]

sashab@chromium.org changed reviewers:
+ alancutter@chromium.org

[sashab, 2016-09-26 05:38:43]

Sorry if I'm sending you a lot of reviews, a lot of the style team is away :P If
it's too much lmk and I'll send these to other people.

[rune, 2016-09-26 07:46:00]

rune@opera.com changed reviewers:
+ rune@opera.com

[rune, 2016-09-26 07:46:01]

lgtm

[commit-bot: I haz the power, 2016-09-26 08:07:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 08:07:04]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[sashab, 2016-09-30 03:01:59]

The CQ bit was checked by sashab@chromium.org

[commit-bot: I haz the power, 2016-09-30 03:02:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 03:09:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 03:09:44]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[sashab, 2016-09-30 03:12:23]

sashab@chromium.org changed reviewers:
+ aboxhall@chromium.org

[sashab, 2016-09-30 03:12:24]

aboxhall@ please rs accvessibility/ :)

[haraken, 2016-09-30 03:13:23]

modules/ LGTM

[sashab, 2016-09-30 03:14:40]

The CQ bit was checked by sashab@chromium.org

[commit-bot: I haz the power, 2016-09-30 03:14:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 04:42:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 04:42:21]

Failed to apply patch for third_party/WebKit/Source/core/style/ComputedStyle.h:
While running git apply --index -3 -p1;
  error: patch failed: third_party/WebKit/Source/core/style/ComputedStyle.h:343
  Falling back to three-way merge...
  Applied patch to 'third_party/WebKit/Source/core/style/ComputedStyle.h' with
conflicts.
  U third_party/WebKit/Source/core/style/ComputedStyle.h

Patch:       third_party/WebKit/Source/core/style/ComputedStyle.h
Index: third_party/WebKit/Source/core/style/ComputedStyle.h
diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.h
b/third_party/WebKit/Source/core/style/ComputedStyle.h
index
d70c43f78d2d162af1cc868f6750a8fcc26fb140..4ead68d41f1278b3da8cea372a438da5a44de80c
100644
--- a/third_party/WebKit/Source/core/style/ComputedStyle.h
+++ b/third_party/WebKit/Source/core/style/ComputedStyle.h
@@ -343,7 +343,7 @@ protected:
     void setBitDefaults()
     {
         ComputedStyleBase::setBitDefaults();
-        m_inheritedData.m_emptyCells = initialEmptyCells();
+        m_inheritedData.m_emptyCells =
static_cast<unsigned>(initialEmptyCells());
         m_inheritedData.m_captionSide = initialCaptionSide();
         m_inheritedData.m_listStyleType = initialListStyleType();
         m_inheritedData.m_listStylePosition = initialListStylePosition();
@@ -1378,9 +1378,9 @@ public:
     void setDirection(TextDirection v) { m_inheritedData.m_direction = v; }
 
     // empty-cells
-    static EEmptyCells initialEmptyCells() { return EmptyCellsShow; }
+    static EEmptyCells initialEmptyCells() { return EEmptyCells::Show; }
     EEmptyCells emptyCells() const { return
static_cast<EEmptyCells>(m_inheritedData.m_emptyCells); }
-    void setEmptyCells(EEmptyCells v) { m_inheritedData.m_emptyCells = v; }
+    void setEmptyCells(EEmptyCells v) { m_inheritedData.m_emptyCells =
static_cast<unsigned>(v); }
 
     // color
     static Color initialColor() { return Color::black; }

[sashab, 2016-09-30 13:12:17]

The CQ bit was checked by sashab@chromium.org

[sashab, 2016-09-30 13:12:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, rune@opera.com
Link to the patchset: https://codereview.chromium.org/2367273003/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2016-09-30 13:12:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 14:21:54]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-30 14:23:32]

Description was changed from

==========
Changed EEmptyCells to an enum class and renamed its members to keywords

Changed EEmptyCells to an enum class and gave it an unsigned underlying
type. Also renamed its members to match its keywords from
CSSValueKeywords.in. This is pre-work to move EEmptyCells to be
generated in ComputedStyleBase.

BUG=628043
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Changed EEmptyCells to an enum class and renamed its members to keywords

Changed EEmptyCells to an enum class and gave it an unsigned underlying
type. Also renamed its members to match its keywords from
CSSValueKeywords.in. This is pre-work to move EEmptyCells to be
generated in ComputedStyleBase.

BUG=628043
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/058937513b328bdf63adfec95f0bfa8cc2c25f99
Cr-Commit-Position: refs/heads/master@{#422106}
==========

[commit-bot: I haz the power, 2016-09-30 14:23:34]

Patchset 2 (id:??) landed as
https://crrev.com/058937513b328bdf63adfec95f0bfa8cc2c25f99
Cr-Commit-Position: refs/heads/master@{#422106}