Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: third_party/WebKit/Source/modules/accessibility/AXTable.cpp

Issue 2367273003: Changed EEmptyCells to an enum class and renamed its members to keywords (Closed)
Patch Set: Rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/style/ComputedStyleConstants.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 224 matching lines...) Expand 10 before | Expand all | Expand 10 after
235 if (!cellElement.headers().isEmpty() || !cellElement.abbr().isEm pty() 235 if (!cellElement.headers().isEmpty() || !cellElement.abbr().isEm pty()
236 || !cellElement.axis().isEmpty() || !cellElement.scope().isE mpty()) 236 || !cellElement.axis().isEmpty() || !cellElement.scope().isE mpty())
237 return true; 237 return true;
238 } 238 }
239 239
240 const ComputedStyle* computedStyle = cell->style(); 240 const ComputedStyle* computedStyle = cell->style();
241 if (!computedStyle) 241 if (!computedStyle)
242 continue; 242 continue;
243 243
244 // If the empty-cells style is set, we'll call it a data table. 244 // If the empty-cells style is set, we'll call it a data table.
245 if (computedStyle->emptyCells() == EmptyCellsHide) 245 if (computedStyle->emptyCells() == EEmptyCells::Hide)
246 return true; 246 return true;
247 247
248 // If a cell has matching bordered sides, call it a (fully) bordered cell. 248 // If a cell has matching bordered sides, call it a (fully) bordered cell.
249 if ((cell->borderTop() > 0 && cell->borderBottom() > 0) 249 if ((cell->borderTop() > 0 && cell->borderBottom() > 0)
250 || (cell->borderLeft() > 0 && cell->borderRight() > 0)) 250 || (cell->borderLeft() > 0 && cell->borderRight() > 0))
251 borderedCellCount++; 251 borderedCellCount++;
252 252
253 // Also keep track of each individual border, so we can catch tables where most 253 // Also keep track of each individual border, so we can catch tables where most
254 // cells have a bottom border, for example. 254 // cells have a bottom border, for example.
255 if (cell->borderTop() > 0) 255 if (cell->borderTop() > 0)
(...skipping 308 matching lines...) Expand 10 before | Expand all | Expand 10 after
564 564
565 DEFINE_TRACE(AXTable) 565 DEFINE_TRACE(AXTable)
566 { 566 {
567 visitor->trace(m_rows); 567 visitor->trace(m_rows);
568 visitor->trace(m_columns); 568 visitor->trace(m_columns);
569 visitor->trace(m_headerContainer); 569 visitor->trace(m_headerContainer);
570 AXLayoutObject::trace(visitor); 570 AXLayoutObject::trace(visitor);
571 } 571 }
572 572
573 } // namespace blink 573 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/style/ComputedStyleConstants.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698