Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 2367273002: net/ lint suppressions needed for Android SDK roll. (Closed)

Created:
4 years, 2 months ago by ghost stip (do not use)
Modified:
4 years, 2 months ago
Reviewers:
jbudorick, Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

net/ lint suppressions needed for Android SDK roll. This is only part of the suppressions needed for a full compile, I'm splitting them up into separate CLs to make OWNERS review easier. BUG=623989 Committed: https://crrev.com/748a60e398d3b38dfc372d56437d3419b230956d Cr-Commit-Position: refs/heads/master@{#422000}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Address jbudorick's comments, add TODO. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java View 1 3 chunks +5 lines, -0 lines 0 comments Download
M net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java View 1 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
ghost stip (do not use)
jbudorick: ptal rsleevi: OWNERS
4 years, 2 months ago (2016-09-26 03:57:02 UTC) #4
jbudorick
lgtm w/ nit https://codereview.chromium.org/2367273002/diff/1/net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java File net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java (right): https://codereview.chromium.org/2367273002/diff/1/net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java#newcode913 net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java:913: "NewApi", "ParcelCreator", nit: can this go ...
4 years, 2 months ago (2016-09-26 13:02:03 UTC) #5
Ryan Sleevi
LGTM w/ Q https://codereview.chromium.org/2367273002/diff/1/net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java File net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java (right): https://codereview.chromium.org/2367273002/diff/1/net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java#newcode402 net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java:402: @SuppressLint("TrustAllX509TrustManager") What's this lint actually about?
4 years, 2 months ago (2016-09-26 15:00:30 UTC) #6
ghost stip (do not use)
https://codereview.chromium.org/2367273002/diff/1/net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java File net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java (right): https://codereview.chromium.org/2367273002/diff/1/net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java#newcode402 net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java:402: @SuppressLint("TrustAllX509TrustManager") On 2016/09/26 15:00:30, Ryan Sleevi (slow) wrote: > ...
4 years, 2 months ago (2016-09-27 15:47:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2367273002/20001
4 years, 2 months ago (2016-09-30 00:07:58 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-30 00:54:44 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 00:56:44 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/748a60e398d3b38dfc372d56437d3419b230956d
Cr-Commit-Position: refs/heads/master@{#422000}

Powered by Google App Engine
This is Rietveld 408576698