Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1027)

Unified Diff: net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java

Issue 2367273002: net/ lint suppressions needed for Android SDK roll. (Closed)
Patch Set: Address jbudorick's comments, add TODO. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java
diff --git a/net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java b/net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java
index e164c739c8e1512646572bf668a3003c77ae7ee2..59fbb9d5d9c25395329478c7a59bb942a3a52234 100644
--- a/net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java
+++ b/net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java
@@ -10,6 +10,7 @@ import static android.net.NetworkCapabilities.NET_CAPABILITY_NOT_VPN;
import static android.net.NetworkCapabilities.TRANSPORT_VPN;
import android.Manifest.permission;
+import android.annotation.SuppressLint;
import android.annotation.TargetApi;
import android.content.BroadcastReceiver;
import android.content.Context;
@@ -40,6 +41,8 @@ import java.util.Arrays;
* Note that use of this class requires that the app have the platform
* ACCESS_NETWORK_STATE permission.
*/
+// TODO(crbug.com/635567): Fix this properly.
+@SuppressLint("NewApi")
public class NetworkChangeNotifierAutoDetect extends BroadcastReceiver {
static class NetworkState {
private final boolean mConnected;
@@ -907,6 +910,8 @@ public class NetworkChangeNotifierAutoDetect extends BroadcastReceiver {
mObserver.onMaxBandwidthChanged(newMaxBandwidthMbps);
}
+ // TODO(crbug.com/635567): Fix this properly.
+ @SuppressLint({"NewApi", "ParcelCreator"})
private static class NetworkConnectivityIntentFilter extends IntentFilter {
NetworkConnectivityIntentFilter(boolean monitorRSSI) {
addAction(ConnectivityManager.CONNECTIVITY_ACTION);
« no previous file with comments | « no previous file | net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698