third_party/WebKit/Source/core/layout/LayoutTable.cpp - Issue 2367243002: Don't repeat header groups when one row of content doesn't fit on the first page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTable.cpp

Issue 2367243002: Don't repeat header groups when one row of content doesn't fit on the first page (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutTable.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutTable.cpp b/third_party/WebKit/Source/core/layout/LayoutTable.cpp

index ffaac3ba83069f870eb5c3b811affb0ef9552635..38961ef6b09c737491c0767b5d21aab5a27c0e4a 100644

--- a/third_party/WebKit/Source/core/layout/LayoutTable.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutTable.cpp

@@ -543,7 +543,7 @@ void LayoutTable::layout()

section->setLogicalTop(logicalOffset);

section->layoutRows();

logicalOffset += section->logicalHeight();

- if (isPaginated && m_head && m_head == section) {

+ if (isPaginated && m_head && m_head == section && section->logicalHeight() < section->pageLogicalHeightForOffset(logicalOffset)) {

LayoutUnit offsetForTableHeaders = state.heightOffsetForTableHeaders();

offsetForTableHeaders += section->logicalHeight();

state.setHeightOffsetForTableHeaders(offsetForTableHeaders);