third_party/WebKit/Source/core/layout/LayoutBox.cpp - Issue 2367243002: Don't repeat header groups when one row of content doesn't fit on the first page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 2367243002: Don't repeat header groups when one row of content doesn't fit on the first page (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutBox.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.cpp b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

index eac327c5497d6b9198d4881793a00c6cee4e4c00..d6ac5c7a279b78694e4a62c9827af337efdc22c2 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBox.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

@@ -4859,7 +4859,7 @@ LayoutUnit LayoutBox::pageRemainingLogicalHeightForOffset(LayoutUnit offset, Pag

LayoutFlowThread* flowThread = flowThreadContainingBlock();

if (!flowThread) {

- LayoutUnit pageLogicalHeight = layoutView->layoutState()->pageLogicalHeight();

+ LayoutUnit pageLogicalHeight = layoutView->pageLogicalHeight();

LayoutUnit remainingHeight = pageLogicalHeight - intMod(offset, pageLogicalHeight);

if (pageBoundaryRule == AssociateWithFormerPage) {

// An offset exactly at a page boundary will act as being part of the former page in