Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 236723005: Restore usage of system default font in webui pages on desktop linux (Closed)

Created:
6 years, 8 months ago by Evan Stade
Modified:
6 years, 8 months ago
Reviewers:
Nico, Elliot Glaysher
CC:
chromium-reviews
Visibility:
Public.

Description

Restore usage of system default font in webui pages on desktop linux BUG=363282 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263763

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M ui/base/webui/web_ui_util.cc View 1 chunk +5 lines, -0 lines 1 comment Download

Messages

Total messages: 8 (0 generated)
Evan Stade
+thakis for OWNERS review +erg for substantive review
6 years, 8 months ago (2014-04-14 18:17:41 UTC) #1
Elliot Glaysher
lgtm
6 years, 8 months ago (2014-04-14 18:24:30 UTC) #2
Nico
https://codereview.chromium.org/236723005/diff/1/ui/base/webui/web_ui_util.cc File ui/base/webui/web_ui_util.cc (right): https://codereview.chromium.org/236723005/diff/1/ui/base/webui/web_ui_util.cc#newcode146 ui/base/webui/web_ui_util.cc:146: #endif Elsewhere we do this by adjusting IDS_WEB_FONT_FAMILY: https://code.google.com/p/chromium/codesearch#chromium/src/ui/base/strings/app_locale_settings.grd&l=224 ...
6 years, 8 months ago (2014-04-14 18:30:44 UTC) #3
Evan Stade
On 2014/04/14 18:30:44, Nico wrote: > https://codereview.chromium.org/236723005/diff/1/ui/base/webui/web_ui_util.cc > File ui/base/webui/web_ui_util.cc (right): > > https://codereview.chromium.org/236723005/diff/1/ui/base/webui/web_ui_util.cc#newcode146 > ...
6 years, 8 months ago (2014-04-14 18:35:31 UTC) #4
Nico
lgtm
6 years, 8 months ago (2014-04-14 18:47:15 UTC) #5
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 8 months ago (2014-04-14 18:47:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/236723005/1
6 years, 8 months ago (2014-04-14 18:49:02 UTC) #7
commit-bot: I haz the power
6 years, 8 months ago (2014-04-15 01:07:13 UTC) #8
Message was sent while issue was closed.
Change committed as 263763

Powered by Google App Engine
This is Rietveld 408576698