Fix possible naming conflict in macro.

Fix possible naming conflict in macro.

The ObserverList macro (FOR_EACH_OBSERVER) uses an iterator named |it|, which can in some cases conflict with locally defined variables.

Make the iterator variable name slightly more unique

BUG=None
R=jar@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224985

[jar (doing other things), 2013-09-23 16:27:15]

LGTM

My review (and probable blame) falls under the "no good deed goes unpunished." 
I think I changed the indent, and short-circuit "if(){" to this macro... but I
should have looked closer and done more fixin'.

Thanks.

https://codereview.chromium.org/23672052/diff/1/base/observer_list.h
File base/observer_list.h (right):

https://codereview.chromium.org/23672052/diff/1/base/observer_list.h#newcode211
base/observer_list.h:211: while ((obs = it_macro.GetNext()) != NULL)            
              \
This looks good... you might even go bigger, to further reduce the chance that
the name will conflict with callers.  Maybe a name like:

it_inside_observer_macro

Alternatively, you could ask why we needed to make this a macro?  Could we turn
this into a template-method that gets inlined?

[Finnur, 2013-09-24 10:07:50]

Thanks for the review and the suggestions.

I changed the name to what you suggested. I'll check this in and think about a
template-method when I'm done with the task at hand.

[commit-bot: I haz the power, 2013-09-24 10:08:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/finnur@chromium.org/23672052/11001

[commit-bot: I haz the power, 2013-09-24 10:17:52]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...

[Finnur, 2013-09-24 10:25:14]

Also removed the following snippet from the changelist description (since it
doesn't make sense to keep a link to a temporary log file forever in the source
code repository):

----- snip -----

The compile error:
http://build.chromium.org/p/tryserver.chromium/builders/linux_clang/builds/14...
... which was fixed with ...
https://codereview.chromium.org/23812010/diff2/50001:53001/chrome/browser/ext...

----- snip -----

[Finnur, 2013-09-24 13:27:09]

Committed patchset #2 manually as r224985 (presubmit successful).