Fix possible naming conflict in macro.

base/observer_list.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_OBSERVER_LIST_H__
 #define BASE_OBSERVER_LIST_H__
 
 #include <algorithm>
 #include <limits>
 #include <vector>
@@ skipping 185 matching lines @@
       ObserverListBase<ObserverType>::Compact();
       DCHECK_EQ(ObserverListBase<ObserverType>::size(), 0U);
     }
   }
 
   bool might_have_observers() const {
     return ObserverListBase<ObserverType>::size() != 0;
   }
 };
 
-#define FOR_EACH_OBSERVER(ObserverType, observer_list, func)         \
-  do {                                                               \
-    if ((observer_list).might_have_observers()) {                    \
-      ObserverListBase<ObserverType>::Iterator it(observer_list);    \
-      ObserverType* obs;                                             \
-      while ((obs = it.GetNext()) != NULL)                           \
-        obs->func;                                                   \
-    }                                                                \
+#define FOR_EACH_OBSERVER(ObserverType, observer_list, func)               \
+  do {                                                                     \
+    if ((observer_list).might_have_observers()) {                          \
+      ObserverListBase<ObserverType>::Iterator it_macro(observer_list);    \
+      ObserverType* obs;                                                   \
+      while ((obs = it_macro.GetNext()) != NULL)                           \

[jar (doing other things), 2013/09/23 16:27:15]

This looks good... you might even go bigger, to further reduce the chance that
the name will conflict with callers.  Maybe a name like:

it_inside_observer_macro

Alternatively, you could ask why we needed to make this a macro?  Could we turn
this into a template-method that gets inlined?

+        obs->func;                                                         \
+    }                                                                      \
   } while (0)
 
 #endif  // BASE_OBSERVER_LIST_H__