Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp

Issue 2367163002: [DevTools] handle navigation after console.log (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp
index 310e57d5268fe23f77e9ada5bd638b551d6332cd..f68382963d477ecc147391172465bdcd0f29f57f 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp
@@ -95,14 +95,17 @@ void V8ConsoleAgentImpl::reportAllMessages()
m_frontend.messageAdded(std::move(expired));
m_frontend.flush();
}
- for (const auto& message : storage->messages())
- reportMessage(message.get(), false);
+ for (const auto& message : storage->messages()) {
+ if (!reportMessage(message.get(), false))
+ return;
+ }
}
-void V8ConsoleAgentImpl::reportMessage(V8ConsoleMessage* message, bool generatePreview)
+bool V8ConsoleAgentImpl::reportMessage(V8ConsoleMessage* message, bool generatePreview)
{
m_frontend.messageAdded(message->buildInspectorObject(m_session, generatePreview));
m_frontend.flush();
+ return m_session->debugger()->hasConsoleMessageStorage(m_session->contextGroupId());
}
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698