Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Side by Side Diff: third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp

Issue 2367163002: [DevTools] handle navigation after console.log (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "platform/v8_inspector/V8ConsoleAgentImpl.h" 5 #include "platform/v8_inspector/V8ConsoleAgentImpl.h"
6 6
7 #include "platform/v8_inspector/V8ConsoleMessage.h" 7 #include "platform/v8_inspector/V8ConsoleMessage.h"
8 #include "platform/v8_inspector/V8DebuggerImpl.h" 8 #include "platform/v8_inspector/V8DebuggerImpl.h"
9 #include "platform/v8_inspector/V8InspectorSessionImpl.h" 9 #include "platform/v8_inspector/V8InspectorSessionImpl.h"
10 #include "platform/v8_inspector/V8StackTraceImpl.h" 10 #include "platform/v8_inspector/V8StackTraceImpl.h"
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
88 .setText(String16::number(storage->expiredCount()) + String16("conso le messages are not shown.")) 88 .setText(String16::number(storage->expiredCount()) + String16("conso le messages are not shown."))
89 .setTimestamp(0) 89 .setTimestamp(0)
90 .build(); 90 .build();
91 expired->setType(protocol::Console::ConsoleMessage::TypeEnum::Log); 91 expired->setType(protocol::Console::ConsoleMessage::TypeEnum::Log);
92 expired->setLine(0); 92 expired->setLine(0);
93 expired->setColumn(0); 93 expired->setColumn(0);
94 expired->setUrl(""); 94 expired->setUrl("");
95 m_frontend.messageAdded(std::move(expired)); 95 m_frontend.messageAdded(std::move(expired));
96 m_frontend.flush(); 96 m_frontend.flush();
97 } 97 }
98 for (const auto& message : storage->messages()) 98 for (const auto& message : storage->messages()) {
99 reportMessage(message.get(), false); 99 if (!reportMessage(message.get(), false))
100 return;
101 }
100 } 102 }
101 103
102 void V8ConsoleAgentImpl::reportMessage(V8ConsoleMessage* message, bool generateP review) 104 bool V8ConsoleAgentImpl::reportMessage(V8ConsoleMessage* message, bool generateP review)
103 { 105 {
104 m_frontend.messageAdded(message->buildInspectorObject(m_session, generatePre view)); 106 m_frontend.messageAdded(message->buildInspectorObject(m_session, generatePre view));
105 m_frontend.flush(); 107 m_frontend.flush();
108 return m_session->debugger()->hasConsoleMessageStorage(m_session->contextGro upId());
106 } 109 }
107 110
108 } // namespace blink 111 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698