Source/core/css/parser/SizesAttributeParser.cpp - Issue 236713005: Use SizesAttributeParser to get the right srcset resource

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/parser/SizesAttributeParser.cpp

Issue 236713005: Use SizesAttributeParser to get the right srcset resource (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@sizes_parser8

Patch Set: Rebase Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/css/parser/MediaQueryTokenizer.cpp ('K') | « Source/core/css/parser/MediaQueryTokenizer.cpp ('k') | Source/core/css/parser/SizesAttributeParserTest.cpp » ('j') | Source/core/html/HTMLImageElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/css/parser/SizesAttributeParser.cpp

diff --git a/Source/core/css/parser/SizesAttributeParser.cpp b/Source/core/css/parser/SizesAttributeParser.cpp

index 4fd32365b7f52f793a534c9e60553c2585ab4ed0..d31b2c1a3d156f2dceef304894a720fc2c25bb6a 100644

--- a/Source/core/css/parser/SizesAttributeParser.cpp

+++ b/Source/core/css/parser/SizesAttributeParser.cpp

@@ -35,8 +35,7 @@ bool SizesAttributeParser::calculateLengthInPixels(TokenIterator startToken, Tok

return true;

}

- }

- if (type == FunctionToken) {

+ } else if (type == FunctionToken) {

// FIXME - Handle calc() functions here!

}

return false;

@@ -101,6 +100,8 @@ bool SizesAttributeParser::parseMediaConditionAndLength(TokenIterator startToken

bool SizesAttributeParser::parse(Vector<MediaQueryToken>& tokens)

{

+ if (tokens.isEmpty())

+ return false;

TokenIterator startToken = tokens.begin();

TokenIterator endToken;

// Split on a comma token, and send the result tokens to be parsed as (media-condition, length) pairs