Source/core/css/parser/MediaQueryTokenizer.cpp - Issue 236713005: Use SizesAttributeParser to get the right srcset resource

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/parser/MediaQueryTokenizer.cpp

Issue 236713005: Use SizesAttributeParser to get the right srcset resource (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@sizes_parser8

Patch Set: Rebase Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/dom/HTMLImageElement/image-sizes-1x.html ('K') | « Source/core/css/MediaValuesDynamic.h ('k') | Source/core/css/parser/SizesAttributeParser.cpp » ('j') | Source/core/html/HTMLImageElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/css/parser/MediaQueryTokenizer.cpp

diff --git a/Source/core/css/parser/MediaQueryTokenizer.cpp b/Source/core/css/parser/MediaQueryTokenizer.cpp

index b97c6a4ea00b7bd16ae1af9d4dd1760b05e013e7..1f5d76dc1fe395bceaaf177b4454752d297cf762 100644

--- a/Source/core/css/parser/MediaQueryTokenizer.cpp

+++ b/Source/core/css/parser/MediaQueryTokenizer.cpp

@@ -213,6 +213,9 @@ void MediaQueryTokenizer::tokenize(String string, Vector<MediaQueryToken>& outTo

// * Do not count white spaces

// * consumeEscape replaces NULLs for replacement characters

+ if (string.isNull() || string.isEmpty())

eseidel 2014/04/19 04:18:46 you only need isEmpty(). isNull implies isEmpty.

+ return;

MediaQueryInputStream input(string);

MediaQueryTokenizer tokenizer(input);

while (true) {