Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Issue 2367113002: Re-enable ChannelMojo between Service process <-> service utility process. (Closed)

Created:
4 years, 3 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 3 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Re-enable ChannelMojo between Service process <-> service utility process. ChannelMojo between Service process <-> service utility process is currently disabled because: -- Service process starts service utility process with a command line containing kMojoChannelToken switch but no kMojoApplicationChannelToken, because they are not in ServiceManager world now. -- But, service utility process(ChildThreadImpl) will disable ChannelMojo because of lack of kMojoApplicationChannelToken switch. This CL lets ChildThreadImpl enable ChannelMojo also for a kMojoChannelToken switch. BUG=646833 TBR=ben@chromium.org Review-Url: https://codereview.chromium.org/2366443004 Cr-Commit-Position: refs/heads/master@{#420566} (cherry picked from commit 3cb38fd23571822bf08c79d90a0ec49ea486492a) Committed: https://chromium.googlesource.com/chromium/src/+/93796f6bee4a682c742639a33d98fb836e3db20a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M content/child/child_thread_impl.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Ken Rockot(use gerrit already)
4 years, 3 months ago (2016-09-23 22:23:14 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
93796f6bee4a682c742639a33d98fb836e3db20a (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698