Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 2366443004: Re-enable ChannelMojo between Service process <-> service utility process. (Closed)

Created:
4 years, 3 months ago by leonhsl(Using Gerrit)
Modified:
4 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable ChannelMojo between Service process <-> service utility process. ChannelMojo between Service process <-> service utility process is currently disabled because: -- Service process starts service utility process with a command line containing kMojoChannelToken switch but no kMojoApplicationChannelToken, because they are not in ServiceManager world now. -- But, service utility process(ChildThreadImpl) will disable ChannelMojo because of lack of kMojoApplicationChannelToken switch. This CL lets ChildThreadImpl enable ChannelMojo also for a kMojoChannelToken switch. BUG=646833 TBR=ben@chromium.org Committed: https://crrev.com/3cb38fd23571822bf08c79d90a0ec49ea486492a Cr-Commit-Position: refs/heads/master@{#420566}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M content/child/child_thread_impl.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
leonhsl(Using Gerrit)
Hi, Ken, Sam, this CL comes from the discussion in crbug.com/646833, would you PTAL? Thanks.
4 years, 3 months ago (2016-09-23 03:14:17 UTC) #6
Ken Rockot(use gerrit already)
LGTM, thanks! Please feel free to TBR ben@ for OWNERS and land this as is.
4 years, 3 months ago (2016-09-23 03:17:17 UTC) #7
leonhsl(Using Gerrit)
On 2016/09/23 03:17:17, Ken Rockot wrote: > LGTM, thanks! Please feel free to TBR ben@ ...
4 years, 3 months ago (2016-09-23 03:23:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2366443004/1
4 years, 3 months ago (2016-09-23 03:23:48 UTC) #11
Sam McNally
lgtm
4 years, 3 months ago (2016-09-23 03:23:52 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-23 03:28:58 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 03:33:28 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3cb38fd23571822bf08c79d90a0ec49ea486492a
Cr-Commit-Position: refs/heads/master@{#420566}

Powered by Google App Engine
This is Rietveld 408576698