Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2366893002: net: address review comments for NetLogWithSource renaming (Closed)

Created:
4 years, 3 months ago by tfarina
Modified:
4 years, 2 months ago
Reviewers:
Lei Zhang, eroman, sdefresne
CC:
chromium-reviews, rsleevi+watch_chromium.org, certificate-transparency-chrome_googlegroups.com, cbentzel+watch_chromium.org, Eran Messeri, extensions-reviews_chromium.org, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, pfeldman, mmenke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

net: address review comments for NetLogWithSource renaming After being committed at https://crrev.com/4283411131bf998401985c4b1784ddaa67dac0d7, some reviewers left comments to be addressed. This patch addresses them. * Alphabetical order of "class NetLogWithSource;" within the block. * Rewrap documentation comments. BUG=475260 R=eroman@chromium.org,sdefresne@chromium.org,thestig@chromium.org TBR=rockot@chromium.org # for trivial change in extensions Committed: https://crrev.com/60a0ae756536daf8f19e930ef8ae2f7b0718c597 Cr-Commit-Position: refs/heads/master@{#420833}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -34 lines) Patch
M chrome/browser/devtools/devtools_network_transaction.h View 1 chunk +1 line, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h View 2 chunks +5 lines, -7 lines 0 comments Download
M extensions/browser/extension_throttle_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M net/cert/cert_verifier.h View 1 chunk +1 line, -1 line 0 comments Download
M net/cert/ct_verifier.h View 1 chunk +1 line, -1 line 0 comments Download
M net/dns/dns_transaction.h View 1 chunk +1 line, -1 line 0 comments Download
M net/dns/host_resolver.h View 1 chunk +1 line, -1 line 0 comments Download
M net/dns/host_resolver_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M net/filter/filter.h View 1 chunk +1 line, -1 line 0 comments Download
M net/http/bidirectional_stream_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M net/http/failing_http_transaction_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_auth.h View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_auth_handler_factory.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/http/http_basic_state.h View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_basic_stream.h View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_stream.h View 2 chunks +1 line, -1 line 0 comments Download
M net/http/http_stream_factory.h View 2 chunks +1 line, -1 line 0 comments Download
M net/http/http_transaction.h View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/client_socket_pool_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/websocket_transport_connect_sub_job.h View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/bidirectional_stream_spdy_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_session.h View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_session_pool.h View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_test_util_common.h View 1 chunk +1 line, -1 line 0 comments Download
M net/udp/datagram_socket.h View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_throttler_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M net/websockets/websocket_test_util.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (10 generated)
tfarina
4 years, 3 months ago (2016-09-23 09:15:57 UTC) #3
sdefresne
components/ lgtm
4 years, 3 months ago (2016-09-23 13:16:12 UTC) #6
Lei Zhang
chrome/ lgtm
4 years, 3 months ago (2016-09-23 16:18:55 UTC) #7
eroman
lgtm
4 years, 3 months ago (2016-09-23 21:03:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2366893002/1
4 years, 3 months ago (2016-09-23 21:07:49 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/285429)
4 years, 3 months ago (2016-09-23 23:05:14 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2366893002/1
4 years, 2 months ago (2016-09-24 05:59:15 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-24 06:56:37 UTC) #17
commit-bot: I haz the power
4 years, 2 months ago (2016-09-24 06:58:02 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/60a0ae756536daf8f19e930ef8ae2f7b0718c597
Cr-Commit-Position: refs/heads/master@{#420833}

Powered by Google App Engine
This is Rietveld 408576698