Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2366863002: Mirror API for IsAsyncFunction (Closed)

Created:
4 years, 3 months ago by Dan Ehrenberg
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com, Yang, gsathya, kozy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Mirror API for IsAsyncFunction DevTools wants to be able to detect async functions in order to print their synopsis better in stack traces and tooltips. This patch provides a simple method to do the check. BUG=v8:4483

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -0 lines) Patch
M src/debug/mirrors.js View 1 chunk +5 lines, -0 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-function.cc View 1 chunk +11 lines, -0 lines 0 comments Download
A test/mjsunit/mirror-function-async.js View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (5 generated)
Dan Ehrenberg
4 years, 3 months ago (2016-09-23 05:21:51 UTC) #4
This patch provides one possible API in V8 to allow DevTools to check whether a
function is an async function. The advantage of this API is that it doesn't
pollute the already-large v8.h, and it doesn't tempt ordinary users to look into
this implementation detail of functions (async functions should be treated just
like any other function that returns a Promise).

jochen, if you have time, a review would be great, as the V8 API owner. An
alternative API is at https://codereview.chromium.org/2365833002 .

Powered by Google App Engine
This is Rietveld 408576698