Add method on Value::IsAsyncFunction to detect async functions

Add method on Value::IsAsyncFunction to detect async functions

DevTools wants to be able to detect async functions in order to print
their synopsis better in stack traces and tooltips. This patch provides a
simple method to do the check.

BUG=v8:4483
Committed: https://crrev.com/713e247e7dd1bdf79b3f596c77a2fc28758de50b
Cr-Commit-Position: refs/heads/master@{#39687}

[Dan Ehrenberg, 2016-09-23 04:58:10]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 04:58:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 05:02:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 05:02:29]

Dry run: Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/24801)

[Dan Ehrenberg, 2016-09-23 05:07:22]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 05:07:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Ehrenberg, 2016-09-23 05:23:33]

littledan@chromium.org changed reviewers:
+ jochen@chromium.org

[Dan Ehrenberg, 2016-09-23 05:23:34]

The advantage of this API is that it is analogous to existing APIs, such as
IsGeneratorFunction. However, it may cause users like Node modules to
inappropriately make decisions about how to treat a function based on whether
it's an async function, as the API is "too easy to use".

jochen, if you have time, a review would be great, as the V8 API owner. An
alternative API is at https://codereview.chromium.org/2366863002

[commit-bot: I haz the power, 2016-09-23 07:07:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 07:07:59]

Dry run: Try jobs failed on following builders:
  v8_mac_rel_ng on master.tryserver.v8 (JOB_TIMED_OUT, no build URL)
  v8_win64_rel_ng on master.tryserver.v8 (JOB_TIMED_OUT, no build URL)
  v8_win_compile_dbg on master.tryserver.v8 (JOB_TIMED_OUT, no build URL)
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_TIMED_OUT, no build
URL)
  v8_win_rel_ng on master.tryserver.v8 (JOB_TIMED_OUT, no build URL)

[Dan Ehrenberg, 2016-09-23 18:16:37]

littledan@chromium.org changed reviewers:
+ adamk@chromium.org

[adamk, 2016-09-23 18:27:44]

lgtm

[Dan Ehrenberg, 2016-09-23 18:28:39]

The CQ bit was checked by littledan@chromium.org

[commit-bot: I haz the power, 2016-09-23 18:28:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 18:31:22]

Committed patchset #2 (id:2)

[commit-bot: I haz the power, 2016-09-23 18:31:37]

Description was changed from

==========
Add method on Value::IsAsyncFunction to detect async functions

DevTools wants to be able to detect async functions in order to print
their synopsis better in stack traces and tooltips. This patch provides a
simple method to do the check.

BUG=v8:4483
==========

to

==========
Add method on Value::IsAsyncFunction to detect async functions

DevTools wants to be able to detect async functions in order to print
their synopsis better in stack traces and tooltips. This patch provides a
simple method to do the check.

BUG=v8:4483

Committed: https://crrev.com/713e247e7dd1bdf79b3f596c77a2fc28758de50b
Cr-Commit-Position: refs/heads/master@{#39687}
==========

[commit-bot: I haz the power, 2016-09-23 18:31:37]

Patchset 2 (id:??) landed as
https://crrev.com/713e247e7dd1bdf79b3f596c77a2fc28758de50b
Cr-Commit-Position: refs/heads/master@{#39687}