Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Issue 236683003: Handlify DebugLookupResultValue. (Closed)

Created:
6 years, 8 months ago by Yang
Modified:
6 years, 8 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Handlify DebugLookupResultValue. R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20729

Patch Set 1 #

Total comments: 4

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -68 lines) Patch
M src/objects.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime.cc View 1 3 chunks +43 lines, -66 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Yang
6 years, 8 months ago (2014-04-14 09:12:12 UTC) #1
ulan
lgtm with comments: https://codereview.chromium.org/236683003/diff/1/src/runtime.cc File src/runtime.cc (right): https://codereview.chromium.org/236683003/diff/1/src/runtime.cc#newcode10747 src/runtime.cc:10747: // Fall through; "break" would be ...
6 years, 8 months ago (2014-04-14 11:25:24 UTC) #2
Yang
https://codereview.chromium.org/236683003/diff/1/src/runtime.cc File src/runtime.cc (right): https://codereview.chromium.org/236683003/diff/1/src/runtime.cc#newcode10747 src/runtime.cc:10747: // Fall through; On 2014/04/14 11:25:25, ulan wrote: > ...
6 years, 8 months ago (2014-04-14 13:12:42 UTC) #3
ulan
lgtm
6 years, 8 months ago (2014-04-14 13:14:33 UTC) #4
Yang
6 years, 8 months ago (2014-04-14 14:00:47 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r20729 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698