Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Side by Side Diff: src/objects.cc

Issue 236683003: Handlify DebugLookupResultValue. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: fix Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/runtime.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 788 matching lines...) Expand 10 before | Expand all | Expand 10 after
799 799
800 if (!result->IsProperty()) { 800 if (!result->IsProperty()) {
801 *attributes = ABSENT; 801 *attributes = ABSENT;
802 return factory->undefined_value(); 802 return factory->undefined_value();
803 } 803 }
804 *attributes = result->GetAttributes(); 804 *attributes = result->GetAttributes();
805 805
806 Handle<Object> value; 806 Handle<Object> value;
807 switch (result->type()) { 807 switch (result->type()) {
808 case NORMAL: { 808 case NORMAL: {
809 DisallowHeapAllocation no_gc; 809 value = JSObject::GetNormalizedProperty(
810 value = handle(result->holder()->GetNormalizedProperty(result), isolate); 810 handle(result->holder(), isolate), result);
811 break; 811 break;
812 } 812 }
813 case FIELD: 813 case FIELD:
814 value = JSObject::FastPropertyAt(handle(result->holder(), isolate), 814 value = JSObject::FastPropertyAt(handle(result->holder(), isolate),
815 result->representation(), 815 result->representation(),
816 result->GetFieldIndex().field_index()); 816 result->GetFieldIndex().field_index());
817 break; 817 break;
818 case CONSTANT: 818 case CONSTANT:
819 return handle(result->GetConstant(), isolate); 819 return handle(result->GetConstant(), isolate);
820 case CALLBACKS: 820 case CALLBACKS:
(...skipping 15661 matching lines...) Expand 10 before | Expand all | Expand 10 after
16482 #define ERROR_MESSAGES_TEXTS(C, T) T, 16482 #define ERROR_MESSAGES_TEXTS(C, T) T,
16483 static const char* error_messages_[] = { 16483 static const char* error_messages_[] = {
16484 ERROR_MESSAGES_LIST(ERROR_MESSAGES_TEXTS) 16484 ERROR_MESSAGES_LIST(ERROR_MESSAGES_TEXTS)
16485 }; 16485 };
16486 #undef ERROR_MESSAGES_TEXTS 16486 #undef ERROR_MESSAGES_TEXTS
16487 return error_messages_[reason]; 16487 return error_messages_[reason];
16488 } 16488 }
16489 16489
16490 16490
16491 } } // namespace v8::internal 16491 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/runtime.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698