Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2366743004: Clean up Panel menu text labels. (Closed)

Created:
4 years, 3 months ago by David Tseng
Modified:
4 years, 2 months ago
Reviewers:
dmazzoni
CC:
aboxhall+watch_chromium.org, alemate+watch_chromium.org, arv+watch_chromium.org, chromium-reviews, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, je_julie, nektar+watch_chromium.org, oshima+watch_chromium.org, yuzo+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up Panel menu text labels. Include role, state, and other possibly useful annotations. Also, correct the heading output rule. BUG=627971 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/fb7c88eb2f4e2216a244ae78142cf2097c8f1076 Cr-Commit-Position: refs/heads/master@{#422277}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -26 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js View 1 3 chunks +40 lines, -25 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_menu.js View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 20 (11 generated)
David Tseng
4 years, 3 months ago (2016-09-23 21:19:33 UTC) #4
dmazzoni
lgtm
4 years, 2 months ago (2016-09-26 15:41:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2366743004/1
4 years, 2 months ago (2016-09-30 15:06:29 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/277798) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 2 months ago (2016-09-30 15:08:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2366743004/20001
4 years, 2 months ago (2016-09-30 17:21:52 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/151615)
4 years, 2 months ago (2016-09-30 18:10:00 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2366743004/20001
4 years, 2 months ago (2016-09-30 23:39:50 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-01 02:06:33 UTC) #18
commit-bot: I haz the power
4 years, 2 months ago (2016-10-01 02:09:08 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fb7c88eb2f4e2216a244ae78142cf2097c8f1076
Cr-Commit-Position: refs/heads/master@{#422277}

Powered by Google App Engine
This is Rietveld 408576698