Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2742)

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_menu.js

Issue 2366743004: Clean up Panel menu text labels. (Closed)
Patch Set: Rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_menu.js
diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_menu.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_menu.js
index 50e0753d37d0643691dfd0fb5a69b4995ce4d2b5..f160480783052f7ac7af4e9c20cd3572ef3a8094 100644
--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_menu.js
+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_menu.js
@@ -9,8 +9,10 @@
goog.provide('PanelMenu');
goog.provide('PanelNodeMenu');
+goog.require('Output');
goog.require('PanelMenuItem');
goog.require('constants');
+goog.require('cursors.Range');
/**
* @param {string} menuMsg The msg id of the menu.
@@ -241,7 +243,11 @@ PanelNodeMenu = function(menuMsg, node, pred) {
selectNext = true;
if (pred(n)) {
- this.addMenuItem(n.name, '', function() {
+ var output = new Output();
+ var range = cursors.Range.fromNode(n);
+ output.withSpeech(range, range, Output.EventType.NAVIGATE);
+ var label = output.toString();
+ this.addMenuItem(label, '', function() {
chrome.extension.getBackgroundPage().ChromeVoxState
.instance['navigateToRange'](cursors.Range.fromNode(n));
});
« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698