Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(825)

Issue 2366683002: MD Settings: Remove drop-shadow from sidenav. (Closed)

Created:
4 years, 3 months ago by dpapad
Modified:
4 years, 3 months ago
Reviewers:
dschuyler
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org, stevenjb
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Remove drop-shadow from sidenav. BUG=624476 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/c95d1cd0197b295e34db4f8cdd4023fca52b1ac4 Cr-Commit-Position: refs/heads/master@{#420442}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M chrome/browser/resources/settings/settings_ui/settings_ui.html View 1 chunk +0 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (6 generated)
dpapad
@stevenjb: This also (surprisingly?) fixes the issue where the subpage was painted on top of ...
4 years, 3 months ago (2016-09-22 18:45:54 UTC) #3
dpapad
On 2016/09/22 at 18:45:54, dpapad wrote: > @stevenjb: This also (surprisingly?) fixes the issue where ...
4 years, 3 months ago (2016-09-22 18:46:25 UTC) #4
dpapad
On 2016/09/22 at 18:46:25, dpapad wrote: > On 2016/09/22 at 18:45:54, dpapad wrote: > > ...
4 years, 3 months ago (2016-09-22 18:49:06 UTC) #5
dschuyler
lgtm
4 years, 3 months ago (2016-09-22 19:01:11 UTC) #8
dschuyler
On 2016/09/22 19:01:11, dschuyler wrote: > lgtm Thanks for doing this. It may seem like ...
4 years, 3 months ago (2016-09-22 19:02:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2366683002/1
4 years, 3 months ago (2016-09-22 19:02:50 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-22 20:22:43 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 20:30:18 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c95d1cd0197b295e34db4f8cdd4023fca52b1ac4
Cr-Commit-Position: refs/heads/master@{#420442}

Powered by Google App Engine
This is Rietveld 408576698