Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 2366783002: MD Settings: Search engine dialog, tweak logic to show "input invalid". (Closed)

Created:
4 years, 3 months ago by dpapad
Modified:
4 years, 2 months ago
Reviewers:
dschuyler
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Search engine dialog, tweak logic to show "input invalid". Before, validation was triggered on focus, which ended up showing the "invalid" message before the user had any chance to type anything. Now validation is only triggered on input, which is less annoying to the user. BUG=621456 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/033d1f2ef2f8e4124eca1c7de9db5a42e58c4601 Cr-Commit-Position: refs/heads/master@{#420670}

Patch Set 1 #

Patch Set 2 : Update test. #

Patch Set 3 : Undo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -18 lines) Patch
M chrome/browser/resources/settings/search_engines_page/search_engine_dialog.html View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/resources/settings/search_engines_page/search_engine_dialog.js View 2 chunks +9 lines, -1 line 0 comments Download
M chrome/test/data/webui/settings/search_engines_page_test.js View 1 2 chunks +14 lines, -15 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
dpapad
Before/after screenshots: http://imgur.com/a/dvpKY
4 years, 3 months ago (2016-09-22 22:30:56 UTC) #5
dschuyler
lgtm
4 years, 2 months ago (2016-09-23 18:14:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2366783002/40001
4 years, 2 months ago (2016-09-23 18:18:53 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-09-23 18:26:09 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-09-23 18:29:39 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/033d1f2ef2f8e4124eca1c7de9db5a42e58c4601
Cr-Commit-Position: refs/heads/master@{#420670}

Powered by Google App Engine
This is Rietveld 408576698