[DevTools] Focus sidebar trees in certain panels by default.

[DevTools] Focus sidebar trees in certain panels by default.

BUG=648516
Committed: https://crrev.com/520c7fd20b1bfc841ae522436b49636a4ee5ccac
Cr-Commit-Position: refs/heads/master@{#420922}

[dgozman, 2016-09-22 20:47:54]

dgozman@chromium.org changed reviewers:
+ einbinder@chromium.org

[dgozman, 2016-09-22 20:47:54]

Could you please take a look?

[einbinder, 2016-09-22 22:48:24]

Maybe we want setDefaultFocusedChild to be setDefaultFocusedDescendant to make
this simpler

https://codereview.chromium.org/2366613003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/audits/AuditsPanel.js (right):

https://codereview.chromium.org/2366613003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/audits/AuditsPanel.js:175:
this._sidebarTree.focus();
Why not this.setDefaultFocusedChild(this.splitWidget().sidebarWidget()) and
this.splitWidget().sidebarWidget().setDefaultFocusedChild(sidebarTree) instead?

[dgozman, 2016-09-23 00:43:09]

https://codereview.chromium.org/2366613003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/audits/AuditsPanel.js (right):

https://codereview.chromium.org/2366613003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/audits/AuditsPanel.js:175:
this._sidebarTree.focus();
On 2016/09/22 22:48:24, einbinder wrote:
> Why not this.setDefaultFocusedChild(this.splitWidget().sidebarWidget()) and
> this.splitWidget().sidebarWidget().setDefaultFocusedChild(sidebarTree)
instead? 

I see two problems in that:
- we call setDefaultFocusedChild on other widget (ideally I'd make it
"protected");
- we have to access sidebarTree.contentElement (which I'd make "protected" as
well).

[dgozman, 2016-09-23 21:02:43]

dgozman@chromium.org changed reviewers:
+ lushnikov@chromium.org

[dgozman, 2016-09-23 21:02:44]

[+lushnikov]

[lushnikov, 2016-09-24 00:06:54]

lgtm, thanks!

[dgozman, 2016-09-24 00:14:57]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2016-09-24 00:15:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-24 01:21:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-24 01:21:05]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[dgozman, 2016-09-26 14:42:37]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2016-09-26 14:43:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 16:03:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 16:03:08]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[dgozman, 2016-09-26 16:16:02]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2016-09-26 16:16:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 17:41:31]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-26 17:43:06]

Description was changed from

==========
[DevTools] Focus sidebar trees in certain panels by default.

BUG=648516
==========

to

==========
[DevTools] Focus sidebar trees in certain panels by default.

BUG=648516

Committed: https://crrev.com/520c7fd20b1bfc841ae522436b49636a4ee5ccac
Cr-Commit-Position: refs/heads/master@{#420922}
==========

[commit-bot: I haz the power, 2016-09-26 17:43:07]

Patchset 1 (id:??) landed as
https://crrev.com/520c7fd20b1bfc841ae522436b49636a4ee5ccac
Cr-Commit-Position: refs/heads/master@{#420922}