Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2366613003: [DevTools] Focus sidebar trees in certain panels by default. (Closed)

Created:
4 years, 3 months ago by dgozman
Modified:
4 years, 2 months ago
Reviewers:
einbinder, lushnikov
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Focus sidebar trees in certain panels by default. BUG=648516 Committed: https://crrev.com/520c7fd20b1bfc841ae522436b49636a4ee5ccac Cr-Commit-Position: refs/heads/master@{#420922}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -10 lines) Patch
M third_party/WebKit/Source/devtools/front_end/audits/AuditsPanel.js View 2 chunks +13 lines, -6 lines 2 comments Download
M third_party/WebKit/Source/devtools/front_end/profiler/ProfilesPanel.js View 2 chunks +8 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js View 2 chunks +8 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js View 3 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (8 generated)
dgozman
Could you please take a look?
4 years, 3 months ago (2016-09-22 20:47:54 UTC) #2
einbinder
Maybe we want setDefaultFocusedChild to be setDefaultFocusedDescendant to make this simpler https://codereview.chromium.org/2366613003/diff/1/third_party/WebKit/Source/devtools/front_end/audits/AuditsPanel.js File third_party/WebKit/Source/devtools/front_end/audits/AuditsPanel.js (right): ...
4 years, 3 months ago (2016-09-22 22:48:24 UTC) #3
dgozman
https://codereview.chromium.org/2366613003/diff/1/third_party/WebKit/Source/devtools/front_end/audits/AuditsPanel.js File third_party/WebKit/Source/devtools/front_end/audits/AuditsPanel.js (right): https://codereview.chromium.org/2366613003/diff/1/third_party/WebKit/Source/devtools/front_end/audits/AuditsPanel.js#newcode175 third_party/WebKit/Source/devtools/front_end/audits/AuditsPanel.js:175: this._sidebarTree.focus(); On 2016/09/22 22:48:24, einbinder wrote: > Why not ...
4 years, 3 months ago (2016-09-23 00:43:09 UTC) #4
dgozman
[+lushnikov]
4 years, 3 months ago (2016-09-23 21:02:44 UTC) #6
lushnikov
lgtm, thanks!
4 years, 2 months ago (2016-09-24 00:06:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2366613003/1
4 years, 2 months ago (2016-09-24 00:15:37 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/302295)
4 years, 2 months ago (2016-09-24 01:21:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2366613003/1
4 years, 2 months ago (2016-09-26 14:43:09 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/286118)
4 years, 2 months ago (2016-09-26 16:03:08 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2366613003/1
4 years, 2 months ago (2016-09-26 16:16:30 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-26 17:41:31 UTC) #18
commit-bot: I haz the power
4 years, 2 months ago (2016-09-26 17:43:07 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/520c7fd20b1bfc841ae522436b49636a4ee5ccac
Cr-Commit-Position: refs/heads/master@{#420922}

Powered by Google App Engine
This is Rietveld 408576698