[DevTools] Focus sidebar trees in certain panels by default.

third_party/WebKit/Source/devtools/front_end/audits/AuditsPanel.js

Index: third_party/WebKit/Source/devtools/front_end/audits/AuditsPanel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/audits/AuditsPanel.js b/third_party/WebKit/Source/devtools/front_end/audits/AuditsPanel.js
index 6e32b4a8a93bbc966389896820f0ad4348f6cd5b..30de90baedbbb47f6085c91787aad19206b6fe75 100644
--- a/third_party/WebKit/Source/devtools/front_end/audits/AuditsPanel.js
+++ b/third_party/WebKit/Source/devtools/front_end/audits/AuditsPanel.js
@@ -38,19 +38,18 @@ WebInspector.AuditsPanel = function()
     this.registerRequiredCSS("ui/panelEnablerView.css");
     this.registerRequiredCSS("audits/auditsPanel.css");
 
-    var sidebarTree = new TreeOutlineInShadow();
-    sidebarTree.registerRequiredCSS("audits/auditsSidebarTree.css");
-    this.panelSidebarElement().appendChild(sidebarTree.element);
-    this.setDefaultFocusedElement(sidebarTree.element);
+    this._sidebarTree = new TreeOutlineInShadow();
+    this._sidebarTree.registerRequiredCSS("audits/auditsSidebarTree.css");
+    this.panelSidebarElement().appendChild(this._sidebarTree.element);
 
     this._auditsItemTreeElement = new WebInspector.AuditsSidebarTreeElement(this);
-    sidebarTree.appendChild(this._auditsItemTreeElement);
+    this._sidebarTree.appendChild(this._auditsItemTreeElement);
 
     this._auditResultsTreeElement = new TreeElement(WebInspector.UIString("RESULTS"), true);
     this._auditResultsTreeElement.selectable = false;
     this._auditResultsTreeElement.listItemElement.classList.add("audits-sidebar-results");
     this._auditResultsTreeElement.expand();
-    sidebarTree.appendChild(this._auditResultsTreeElement);
+    this._sidebarTree.appendChild(this._auditResultsTreeElement);
 
     this._constructCategories();
 
@@ -168,6 +167,14 @@ WebInspector.AuditsPanel.prototype = {
             this._auditsItemTreeElement.select();
     },
 
+    /**
+     * @override
+     */
+    focus: function()
+    {
+        this._sidebarTree.focus();

[einbinder, 2016/09/22 22:48:24]

Why not this.setDefaultFocusedChild(this.splitWidget().sidebarWidget()) and
this.splitWidget().sidebarWidget().setDefaultFocusedChild(sidebarTree) instead? 

[dgozman, 2016/09/23 00:43:09]

I see two problems in that:
- we call setDefaultFocusedChild on other widget (ideally I'd make it
"protected");
- we have to access sidebarTree.contentElement (which I'd make "protected" as
well).

+    },
+
     clearResults: function()
     {
         this._auditsItemTreeElement.revealAndSelect();