Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 2366493002: CSS Motion Path: report use of deprecated motion* properties (Closed)

Created:
4 years, 3 months ago by Eric Willigers
Modified:
4 years, 2 months ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CSS Motion Path: report use of deprecated motion* properties We report deprecation warnings when the old motion* property names are used. Discussed in the offset-path Intent To Ship, https://groups.google.com/a/chromium.org/d/msg/blink-dev/o1C5NzGf9Q0/sbaLF1MbAgAJ BUG=637543 Committed: https://crrev.com/c49a0a4cd2d0cbb1a42fdb7d22540139058592ff Cr-Commit-Position: refs/heads/master@{#420596}

Patch Set 1 #

Patch Set 2 : GarbageCollectedFinalized #

Patch Set 3 : expectations #

Patch Set 4 : two tests #

Patch Set 5 : M58 #

Patch Set 6 : 58 -> M58 #

Messages

Total messages: 28 (19 generated)
Eric Willigers
4 years, 2 months ago (2016-09-23 03:10:32 UTC) #10
Timothy Loh
On 2016/09/23 03:10:32, Eric Willigers wrote: Not sure if we should be using replacedBy here, ...
4 years, 2 months ago (2016-09-23 03:41:40 UTC) #11
Eric Willigers
On 2016/09/23 03:41:40, Timothy Loh wrote: > On 2016/09/23 03:10:32, Eric Willigers wrote: > > ...
4 years, 2 months ago (2016-09-23 04:43:57 UTC) #12
Timothy Loh
On 2016/09/23 04:43:57, Eric Willigers wrote: > On 2016/09/23 03:41:40, Timothy Loh wrote: > > ...
4 years, 2 months ago (2016-09-23 04:48:24 UTC) #13
Eric Willigers
> Are we warning on 'motion-path' when you use 'motion' because it makes the > ...
4 years, 2 months ago (2016-09-23 04:52:19 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2366493002/100001
4 years, 2 months ago (2016-09-23 07:29:15 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2366493002/100001
4 years, 2 months ago (2016-09-23 10:30:34 UTC) #24
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 2 months ago (2016-09-23 11:33:48 UTC) #26
commit-bot: I haz the power
4 years, 2 months ago (2016-09-23 11:35:50 UTC) #28
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/c49a0a4cd2d0cbb1a42fdb7d22540139058592ff
Cr-Commit-Position: refs/heads/master@{#420596}

Powered by Google App Engine
This is Rietveld 408576698