Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: third_party/WebKit/Source/core/frame/Deprecation.cpp

Issue 2366493002: CSS Motion Path: report use of deprecated motion* properties (Closed)
Patch Set: 58 -> M58 Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/css3/motion-path/motion-shorthand-deprecated-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/frame/Deprecation.cpp
diff --git a/third_party/WebKit/Source/core/frame/Deprecation.cpp b/third_party/WebKit/Source/core/frame/Deprecation.cpp
index 07965515e7b6a4c34df7cc4efa683fb63f52bdb3..dffbd0a878f90c1e796699637212074ce6d4a67e 100644
--- a/third_party/WebKit/Source/core/frame/Deprecation.cpp
+++ b/third_party/WebKit/Source/core/frame/Deprecation.cpp
@@ -121,9 +121,18 @@ void Deprecation::warnOnDeprecatedProperties(const LocalFrame* frame, CSSPropert
String Deprecation::deprecationMessage(CSSPropertyID unresolvedProperty)
{
- // TODO: Add a switch here when there are properties that we intend to deprecate.
- // Returning an empty string for now.
- return emptyString();
+ switch (unresolvedProperty) {
+ case CSSPropertyAliasMotionOffset:
+ return willBeRemoved("motion-offset", M58, "6390764217040896");
+ case CSSPropertyAliasMotionRotation:
+ return willBeRemoved("motion-rotation", M58, "6390764217040896");
+ case CSSPropertyAliasMotionPath:
+ case CSSPropertyMotion:
+ return willBeRemoved("motion-path", M58, "6390764217040896");
+
+ default:
+ return emptyString();
+ }
}
void Deprecation::countDeprecation(const LocalFrame* frame, UseCounter::Feature feature)
« no previous file with comments | « third_party/WebKit/LayoutTests/css3/motion-path/motion-shorthand-deprecated-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698