Changed ECaptionSide to an enum class and renamed its members to keywords

Changed ECaptionSide to an enum class and renamed its members to keywords

Changed ECaptionSide to an enum class and gave it an unsigned underlying
type so it can be stored in a bitfield in the future. Also renamed its
members to match its keywords from CSSValueKeywords.in. This is pre-work
to move ECaptionSide to be generated in ComputedStyleBase.

BUG=628043
Committed: https://crrev.com/fdc8d0ce1cd52ee647079b8a71d6871a87cf1fdc
Cr-Commit-Position: refs/heads/master@{#422029}

[sashab, 2016-09-26 05:47:29]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 05:47:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 07:17:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 07:17:23]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[sashab, 2016-09-29 04:19:09]

sashab@chromium.org changed reviewers:
+ bugsnash@chromium.org

[Bugs Nash, 2016-09-29 04:39:59]

On 2016/09/29 at 04:19:10, sashab wrote:
> 

why is the enum type being changed to unsigned?

[sashab, 2016-09-29 04:43:09]

On 2016/09/29 at 04:39:59, bugsnash wrote:
> On 2016/09/29 at 04:19:10, sashab wrote:
> > 
> 
> why is the enum type being changed to unsigned?

Huh, I thought there was a comment for this.

Basically because we want to store them in bitfields, and bitfield enums need to
have unsigned underlying types.

See my patch to clang in progress here which will add a warning for it. If this
doesn't land I'll add a clang plugin just for Chrome:
https://reviews.llvm.org/D24289

[Bugs Nash, 2016-09-29 04:47:32]

On 2016/09/29 at 04:43:09, sashab wrote:
> On 2016/09/29 at 04:39:59, bugsnash wrote:
> > On 2016/09/29 at 04:19:10, sashab wrote:
> > > 
> > 
> > why is the enum type being changed to unsigned?
> 
> Huh, I thought there was a comment for this.
> 
> Basically because we want to store them in bitfields, and bitfield enums need
to have unsigned underlying types.
> 
> See my patch to clang in progress here which will add a warning for it. If
this doesn't land I'll add a clang plugin just for Chrome:
https://reviews.llvm.org/D24289

You're right there is a comment in ComputedStyleConstants about this. Please
also add to patch description.

lgtm (with description nit)

[sashab, 2016-09-29 04:48:26]

Description was changed from

==========
Changed ECaptionSide to an enum class and renamed its members to keywords

Changed ECaptionSide to an enum class and gave it an unsigned underlying
type. Also renamed its members to match its keywords from
CSSValueKeywords.in. This is pre-work to move ECaptionSide to be
generated in ComputedStyleBase.

BUG=628043
==========

to

==========
Changed ECaptionSide to an enum class and renamed its members to keywords

Changed ECaptionSide to an enum class and gave it an unsigned underlying
type so it can be stored in a bitfield in the future. Also renamed its
members to match its keywords from CSSValueKeywords.in. This is pre-work
to move ECaptionSide to be generated in ComputedStyleBase.

BUG=628043
==========

[rune, 2016-09-29 07:44:48]

rune@opera.com changed reviewers:
+ rune@opera.com

[rune, 2016-09-29 07:44:48]

lgtm

[sashab, 2016-09-30 03:01:08]

The CQ bit was checked by sashab@chromium.org

[commit-bot: I haz the power, 2016-09-30 03:01:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 04:40:58]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-30 04:43:49]

Description was changed from

==========
Changed ECaptionSide to an enum class and renamed its members to keywords

Changed ECaptionSide to an enum class and gave it an unsigned underlying
type so it can be stored in a bitfield in the future. Also renamed its
members to match its keywords from CSSValueKeywords.in. This is pre-work
to move ECaptionSide to be generated in ComputedStyleBase.

BUG=628043
==========

to

==========
Changed ECaptionSide to an enum class and renamed its members to keywords

Changed ECaptionSide to an enum class and gave it an unsigned underlying
type so it can be stored in a bitfield in the future. Also renamed its
members to match its keywords from CSSValueKeywords.in. This is pre-work
to move ECaptionSide to be generated in ComputedStyleBase.

BUG=628043

Committed: https://crrev.com/fdc8d0ce1cd52ee647079b8a71d6871a87cf1fdc
Cr-Commit-Position: refs/heads/master@{#422029}
==========

[commit-bot: I haz the power, 2016-09-30 04:43:50]

Patchset 1 (id:??) landed as
https://crrev.com/fdc8d0ce1cd52ee647079b8a71d6871a87cf1fdc
Cr-Commit-Position: refs/heads/master@{#422029}