Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2366273002: Move caption-side to be generated in ComputedStyleBase (Closed)

Created:
4 years, 2 months ago by sashab
Modified:
4 years, 1 month ago
Reviewers:
Timothy Loh
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move caption-side to be generated in ComputedStyleBase Move the inherited property caption-side and its enum, ECaptionSide, to be generated in ComputedStyleBase. BUG=628043 Committed: https://crrev.com/0ce4167b0c7c65b94600703fc7f9f166b2f2b042 Cr-Commit-Position: refs/heads/master@{#433479}

Patch Set 1 #

Patch Set 2 : Rebase after reformatting #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -17 lines) Patch
M third_party/WebKit/Source/core/css/CSSProperties.in View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 2 3 4 4 chunks +1 line, -13 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 22 (15 generated)
sashab
4 years, 1 month ago (2016-11-15 03:44:24 UTC) #6
Timothy Loh
On 2016/11/15 03:44:24, sashab wrote: lgtm
4 years, 1 month ago (2016-11-15 06:00:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2366273002/20001
4 years, 1 month ago (2016-11-16 02:07:04 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/306637)
4 years, 1 month ago (2016-11-16 02:10:19 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2366273002/80001
4 years, 1 month ago (2016-11-21 03:32:04 UTC) #18
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 1 month ago (2016-11-21 05:51:45 UTC) #20
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 05:54:02 UTC) #22
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/0ce4167b0c7c65b94600703fc7f9f166b2f2b042
Cr-Commit-Position: refs/heads/master@{#433479}

Powered by Google App Engine
This is Rietveld 408576698