third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp - Issue 2366253002: Remove ActiveDOMObject::stop()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp

Issue 2366253002: Remove ActiveDOMObject::stop() (Closed)

Patch Set: temp Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/workers/WorkerThread.cpp ('K') | « third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h ('k') | third_party/WebKit/Source/modules/peerconnection/RTCSessionDescriptionRequestImpl.h » ('j') | third_party/WebKit/Source/modules/presentation/PresentationAvailability.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp

diff --git a/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp b/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp

index 0b5da73fdfc6306de20a2d17d59ac86407cfc968..c43de77b699ba9b1255242a3cfcb6f535979335f 100644

--- a/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp

+++ b/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp

@@ -1354,7 +1354,7 @@ void RTCPeerConnection::didAddRemoteDataChannel(

}

void RTCPeerConnection::releasePeerConnectionHandler() {

- stop();

+ contextDestroyed();

}

void RTCPeerConnection::closePeerConnection() {

@@ -1378,7 +1378,7 @@ void RTCPeerConnection::resume() {

m_dispatchScheduledEventRunner->resume();

}

-void RTCPeerConnection::stop() {

+void RTCPeerConnection::contextDestroyed() {

if (m_stopped)

return;