Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Unified Diff: third_party/WebKit/Source/modules/indexeddb/IDBRequestTest.cpp

Issue 2366253002: Remove ActiveDOMObject::stop() (Closed)
Patch Set: temp Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/indexeddb/IDBRequestTest.cpp
diff --git a/third_party/WebKit/Source/modules/indexeddb/IDBRequestTest.cpp b/third_party/WebKit/Source/modules/indexeddb/IDBRequestTest.cpp
index 48509a0138d97d9dd1fd474bee534ff02ef84362..d71b49a17c502161c03733ecd652a2a351b7b279 100644
--- a/third_party/WebKit/Source/modules/indexeddb/IDBRequestTest.cpp
+++ b/third_party/WebKit/Source/modules/indexeddb/IDBRequestTest.cpp
@@ -54,7 +54,7 @@ TEST(IDBRequestTest, EventsAfterStopping) {
IDBRequest* request = IDBRequest::create(
scope.getScriptState(), IDBAny::createUndefined(), transaction);
EXPECT_EQ(request->readyState(), "pending");
- scope.getExecutionContext()->stopActiveDOMObjects();
+ scope.getExecutionContext()->notifyContextDestroyed();
// Ensure none of the following raise assertions in stopped state:
request->onError(DOMException::create(AbortError, "Description goes here."));
@@ -85,7 +85,7 @@ TEST(IDBRequestTest, AbortErrorAfterAbort) {
// Stop the request lest it be GCed and its destructor
// finds the object in a pending state (and asserts.)
- scope.getExecutionContext()->stopActiveDOMObjects();
+ scope.getExecutionContext()->notifyContextDestroyed();
}
TEST(IDBRequestTest, ConnectionsAfterStopping) {
@@ -104,7 +104,7 @@ TEST(IDBRequestTest, ConnectionsAfterStopping) {
scope.getScriptState(), callbacks, transactionId, version);
EXPECT_EQ(request->readyState(), "pending");
- scope.getExecutionContext()->stopActiveDOMObjects();
+ scope.getExecutionContext()->notifyContextDestroyed();
request->onUpgradeNeeded(oldVersion, std::move(backend), metadata,
WebIDBDataLossNone, String());
}
@@ -116,7 +116,7 @@ TEST(IDBRequestTest, ConnectionsAfterStopping) {
scope.getScriptState(), callbacks, transactionId, version);
EXPECT_EQ(request->readyState(), "pending");
- scope.getExecutionContext()->stopActiveDOMObjects();
+ scope.getExecutionContext()->notifyContextDestroyed();
request->onSuccess(std::move(backend), metadata);
}
}

Powered by Google App Engine
This is Rietveld 408576698