third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp - Issue 2366253002: Remove ActiveDOMObject::stop()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp

Issue 2366253002: Remove ActiveDOMObject::stop() (Closed)

Patch Set: temp Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp

diff --git a/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp b/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp

index 7e09b0ea9eaa6630d1fe2ddd79a0b28ee505c9b8..ff41d83ab56e9219871f47ccdcf3019e7d6e2295 100644

--- a/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp

+++ b/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp

@@ -114,7 +114,6 @@ KURL WorkerGlobalScope::completeURL(const String& url) const {

void WorkerGlobalScope::dispose() {

DCHECK(thread()->isCurrentThread());

- stopActiveDOMObjects();

// Event listeners would keep DOMWrapperWorld objects alive for too long.

// Also, they have references to JS objects, which become dangling once Heap