third_party/WebKit/Source/core/frame/DOMTimer.h - Issue 2366253002: Remove ActiveDOMObject::stop()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/DOMTimer.h

Issue 2366253002: Remove ActiveDOMObject::stop() (Closed)

Patch Set: temp Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/DOMTimer.h

diff --git a/third_party/WebKit/Source/core/frame/DOMTimer.h b/third_party/WebKit/Source/core/frame/DOMTimer.h

index 947cdbb213724bdf85640f93023baf21f18e626d..2f246738d970042d1bce88a3e6cc913d294aab72 100644

--- a/third_party/WebKit/Source/core/frame/DOMTimer.h

+++ b/third_party/WebKit/Source/core/frame/DOMTimer.h

@@ -53,7 +53,7 @@ class CORE_EXPORT DOMTimer final : public GarbageCollectedFinalized<DOMTimer>,

~DOMTimer() override;

// ActiveDOMObject

- void stop() override;

+ void contextDestroyed() override;

// Eager finalization is needed to promptly stop this Timer object.

// Otherwise timer events might fire at an object that's slated for destruction

@@ -62,7 +62,7 @@ class CORE_EXPORT DOMTimer final : public GarbageCollectedFinalized<DOMTimer>,

EAGERLY_FINALIZE();

DECLARE_VIRTUAL_TRACE();

- void disposeTimer();

+ void stop() override;

private:

friend class DOMTimerCoordinator; // For create().