Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1115)

Unified Diff: third_party/WebKit/Source/core/dom/ExecutionContext.cpp

Issue 2366253002: Remove ActiveDOMObject::stop() (Closed)
Patch Set: temp Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/ExecutionContext.cpp
diff --git a/third_party/WebKit/Source/core/dom/ExecutionContext.cpp b/third_party/WebKit/Source/core/dom/ExecutionContext.cpp
index c6ae7ccd16c985e0c3887797a55d1b14c8451c65..a8a83ade92767551a1b3db10c9226585ead165f0 100644
--- a/third_party/WebKit/Source/core/dom/ExecutionContext.cpp
+++ b/third_party/WebKit/Source/core/dom/ExecutionContext.cpp
@@ -67,11 +67,6 @@ void ExecutionContext::resumeActiveDOMObjects() {
notifyResumingActiveDOMObjects();
}
-void ExecutionContext::stopActiveDOMObjects() {
- m_activeDOMObjectsAreStopped = true;
- notifyStoppingActiveDOMObjects();
-}
-
void ExecutionContext::postSuspendableTask(
std::unique_ptr<SuspendableTask> task) {
m_suspendedTasks.append(std::move(task));
@@ -82,6 +77,8 @@ void ExecutionContext::postSuspendableTask(
}
void ExecutionContext::notifyContextDestroyed() {
+ m_activeDOMObjectsAreStopped = true;
+
Deque<std::unique_ptr<SuspendableTask>> suspendedTasks;
suspendedTasks.swap(m_suspendedTasks);
for (Deque<std::unique_ptr<SuspendableTask>>::iterator it =

Powered by Google App Engine
This is Rietveld 408576698