Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1731)

Unified Diff: third_party/WebKit/Source/core/style/ComputedStyleConstants.h

Issue 2366243002: Remove all ordering requirements in CSSValueKeywords.in (WIP) (Closed)
Patch Set: Some mor efixes Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/style/ComputedStyleConstants.h
diff --git a/third_party/WebKit/Source/core/style/ComputedStyleConstants.h b/third_party/WebKit/Source/core/style/ComputedStyleConstants.h
index dd0e2c0f02d24672ad55c61fd3022fc33050d103..86333a2c295f6d80d7385fdf73ffd4bad867b60b 100644
--- a/third_party/WebKit/Source/core/style/ComputedStyleConstants.h
+++ b/third_party/WebKit/Source/core/style/ComputedStyleConstants.h
@@ -97,8 +97,7 @@ enum ColumnSpan { ColumnSpanNone = 0, ColumnSpanAll };
enum EBorderCollapse { BorderCollapseSeparate = 0, BorderCollapseCollapse = 1 };
// These have been defined in the order of their precedence for
-// border-collapsing. Do not change this order! This order also must match the
-// order in CSSValueKeywords.in.
+// border-collapsing. Do not change this order!
enum EBorderStyle {
BorderStyleNone,
BorderStyleHidden,
@@ -268,8 +267,6 @@ enum LineBreak {
enum EResize { RESIZE_NONE, RESIZE_BOTH, RESIZE_HORIZONTAL, RESIZE_VERTICAL };
-// The order of this enum must match the order of the list style types in
-// CSSValueKeywords.in.
enum EListStyleType {
Disc,
Circle,
@@ -335,8 +332,6 @@ enum EAnimPlayState { AnimPlayStatePlaying, AnimPlayStatePaused };
enum EWhiteSpace { NORMAL, PRE, PRE_WRAP, PRE_LINE, NOWRAP, KHTML_NOWRAP };
-// The order of this enum must match the order of the text align values in
-// CSSValueKeywords.in.
enum ETextAlign {
LEFT,
RIGHT,
@@ -433,7 +428,6 @@ enum class ECaptionSide : unsigned { Top, Bottom, Left, Right };
enum class EListStylePosition : unsigned { Outside, Inside };
enum ECursor {
- // The following must match the order in CSSValueKeywords.in.
CURSOR_AUTO,
CURSOR_CROSS,
CURSOR_DEFAULT,
@@ -468,14 +462,10 @@ enum ECursor {
CURSOR_ALL_SCROLL,
CURSOR_WEBKIT_GRAB,
CURSOR_WEBKIT_GRABBING,
-
- // The following are handled as exceptions so don't need to match.
CURSOR_COPY,
CURSOR_NONE
};
-// The order of this enum must match the order of the display values in
-// CSSValueKeywords.in.
enum class EDisplay : unsigned {
Inline,
Block,
« no previous file with comments | « third_party/WebKit/Source/core/editing/EditingStyle.cpp ('k') | third_party/WebKit/Source/platform/ThemeTypes.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698