Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Issue 2366123002: Switch the RootLayerScrolls codepath to use root effect paint properties (Closed)

Created:
4 years, 2 months ago by pdr.
Modified:
4 years, 2 months ago
Reviewers:
chrishtr, szager1, trchen
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-paint_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, slimming-paint-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch the RootLayerScrolls codepath to use root effect paint properties This is a followup to [1] to start moving the root layer scrolls codepath to use the new root property tree nodes. Only the effect node has been done in this patch. [1] https://crrev.com/a518f5340802393f8bdaa6b3d376dc5482049351 BUG=645615 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/80f2dd56da341a600b19f74b45e0aaae52fdb1d7 Cr-Commit-Position: refs/heads/master@{#421056}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -11 lines) Patch
M third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp View 2 chunks +2 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/EffectPaintPropertyNode.h View 2 chunks +6 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 21 (10 generated)
pdr.
4 years, 2 months ago (2016-09-26 16:34:35 UTC) #7
chrishtr
Is there a test exercising this?
4 years, 2 months ago (2016-09-26 20:32:09 UTC) #8
pdr.
On 2016/09/26 at 20:32:09, chrishtr wrote: > Is there a test exercising this? Yeah, this ...
4 years, 2 months ago (2016-09-26 20:35:06 UTC) #9
chrishtr
lgtm
4 years, 2 months ago (2016-09-26 20:54:04 UTC) #10
pdr.
On 2016/09/26 at 20:54:04, chrishtr wrote: > lgtm Stefan had some questions in the followup ...
4 years, 2 months ago (2016-09-26 20:57:23 UTC) #11
szager1
lgtm
4 years, 2 months ago (2016-09-26 21:02:18 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2366123002/1
4 years, 2 months ago (2016-09-26 21:03:27 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/148411)
4 years, 2 months ago (2016-09-26 22:37:35 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2366123002/1
4 years, 2 months ago (2016-09-26 23:05:03 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 00:54:38 UTC) #19
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 01:02:12 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/80f2dd56da341a600b19f74b45e0aaae52fdb1d7
Cr-Commit-Position: refs/heads/master@{#421056}

Powered by Google App Engine
This is Rietveld 408576698