Switch the RootLayerScrolls codepath to use root effect paint properties

Switch the RootLayerScrolls codepath to use root effect paint properties

This is a followup to [1] to start moving the root layer scrolls
codepath to use the new root property tree nodes. Only the effect node
has been done in this patch.

[1] https://crrev.com/a518f5340802393f8bdaa6b3d376dc5482049351

BUG=645615
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/80f2dd56da341a600b19f74b45e0aaae52fdb1d7
Cr-Commit-Position: refs/heads/master@{#421056}

[pdr., 2016-09-24 04:25:06]

Description was changed from

==========
Switch the RootLayerScrolls codepath to use root effect paint properties

This is a followup to [1] to start moving the root layer scrolls
codepath to use the new root property tree nodes. Only the effect node
has been done in this patch.

[1] https://crrev.com/a518f5340802393f8bdaa6b3d376dc5482049351

BUG=645615
==========

to

==========
Switch the RootLayerScrolls codepath to use root effect paint properties

This is a followup to [1] to start moving the root layer scrolls
codepath to use the new root property tree nodes. Only the effect node
has been done in this patch.

[1] https://crrev.com/a518f5340802393f8bdaa6b3d376dc5482049351

BUG=645615
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[pdr., 2016-09-24 04:25:34]

The CQ bit was checked by pdr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-24 04:25:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-24 05:38:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-24 05:38:35]

Dry run: This issue passed the CQ dry run.

[pdr., 2016-09-26 16:23:14]

pdr@chromium.org changed reviewers:
+ chrishtr@chromium.org, szager@chromium.org, trchen@chromium.org

[chrishtr, 2016-09-26 20:32:09]

Is there a test exercising this?

[pdr., 2016-09-26 20:35:06]

On 2016/09/26 at 20:32:09, chrishtr wrote:
> Is there a test exercising this?

Yeah, this code is heavily tested in PaintPropertyTreeBuilderTest. The goal here
is to move both the RLS and non-RLS codepaths onto the same root paint property
tree nodes. No tests changing proves this patch is awesome possum.

[chrishtr, 2016-09-26 20:54:04]

lgtm

[pdr., 2016-09-26 20:57:23]

On 2016/09/26 at 20:54:04, chrishtr wrote:
> lgtm

Stefan had some questions in the followup patch
(https://codereview.chromium.org/2364103003/#ps1) so I'd like to give him a
chance to respond here.

@szager, please LGTM + CQ if you like this.

[szager1, 2016-09-26 21:02:17]

The CQ bit was checked by szager@chromium.org

[szager1, 2016-09-26 21:02:18]

lgtm

[commit-bot: I haz the power, 2016-09-26 21:03:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 22:37:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 22:37:35]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[pdr., 2016-09-26 23:04:34]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2016-09-26 23:05:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 00:54:38]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-27 01:02:11]

Description was changed from

==========
Switch the RootLayerScrolls codepath to use root effect paint properties

This is a followup to [1] to start moving the root layer scrolls
codepath to use the new root property tree nodes. Only the effect node
has been done in this patch.

[1] https://crrev.com/a518f5340802393f8bdaa6b3d376dc5482049351

BUG=645615
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Switch the RootLayerScrolls codepath to use root effect paint properties

This is a followup to [1] to start moving the root layer scrolls
codepath to use the new root property tree nodes. Only the effect node
has been done in this patch.

[1] https://crrev.com/a518f5340802393f8bdaa6b3d376dc5482049351

BUG=645615
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/80f2dd56da341a600b19f74b45e0aaae52fdb1d7
Cr-Commit-Position: refs/heads/master@{#421056}
==========

[commit-bot: I haz the power, 2016-09-27 01:02:12]

Patchset 1 (id:??) landed as
https://crrev.com/80f2dd56da341a600b19f74b45e0aaae52fdb1d7
Cr-Commit-Position: refs/heads/master@{#421056}