Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Unified Diff: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp

Issue 2366123002: Switch the RootLayerScrolls codepath to use root effect paint properties (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/graphics/paint/EffectPaintPropertyNode.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
diff --git a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
index 669e7c1553be867de3774da5748084f3189f824a..d08285c972d1e0471441996723d65627e611b7ae 100644
--- a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
+++ b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
@@ -51,14 +51,14 @@ PaintPropertyTreeBuilderContext PaintPropertyTreeBuilder::setupInitialContext()
PaintPropertyTreeBuilderContext context;
context.current.clip = context.absolutePosition.clip = context.fixedPosition.clip = rootClipNode();
+ context.currentEffect = rootEffectNode();
- // TODO(pdr): Update the root layer scrolling paths to use the static root nodes for transform, effect, and scroll.
+ // TODO(pdr): Update the root layer scrolling paths to use the static root nodes for transform and scroll.
if (RuntimeEnabledFeatures::rootLayerScrollingEnabled())
return context;
context.current.transform = context.absolutePosition.transform = context.fixedPosition.transform = rootTransformNode();
context.current.scroll = context.absolutePosition.scroll = context.fixedPosition.scroll = rootScrollNode();
- context.currentEffect = rootEffectNode();
// Ensure scroll tree properties are reset. They will be rebuilt during the tree walk.
rootScrollNode()->clearMainThreadScrollingReasons();
@@ -279,14 +279,6 @@ void PaintPropertyTreeBuilder::updateTransform(const LayoutObject& object, Paint
void PaintPropertyTreeBuilder::updateEffect(const LayoutObject& object, PaintPropertyTreeBuilderContext& context)
{
- if (object.isLayoutView() && !context.currentEffect) {
- const LayoutView& layoutView = toLayoutView(object);
- DCHECK(RuntimeEnabledFeatures::rootLayerScrollingEnabled());
- DCHECK(layoutView.frameView()->frame().isMainFrame());
- context.currentEffect = layoutView.getMutableForPainting().ensureObjectPaintProperties().createOrUpdateEffect(nullptr, 1.0);
- return;
- }
-
if (!object.styleRef().hasOpacity()) {
if (ObjectPaintProperties* properties = object.getMutableForPainting().objectPaintProperties())
properties->clearEffect();
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/graphics/paint/EffectPaintPropertyNode.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698