[modules] Initialize requested_modules before recursing in Module::Instantiate

[modules] Initialize requested_modules before recursing in Module::Instantiate

Also fix recursive call to avoid going back through the API.

R=neis@chromium.org
BUG=v8:1569
Committed: https://crrev.com/756f669003356ce909b91923dee93d8dfd692b67
Cr-Commit-Position: refs/heads/master@{#39696}

[adamk, 2016-09-23 22:38:53]

The CQ bit was checked by adamk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 22:39:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[neis, 2016-09-23 22:52:49]

lgtm, one comment

https://codereview.chromium.org/2366063002/diff/1/test/mjsunit/modules-skip-c...
File test/mjsunit/modules-skip-circular-valid.js (right):

https://codereview.chromium.org/2366063002/diff/1/test/mjsunit/modules-skip-c...
test/mjsunit/modules-skip-circular-valid.js:7: assertSame(a, b);
Can you add assertEquals({}, a) as well? THanks.

[adamk, 2016-09-23 22:56:23]

The CQ bit was checked by adamk@chromium.org

[adamk, 2016-09-23 22:56:23]

The patchset sent to the CQ was uploaded after l-g-t-m from neis@chromium.org
Link to the patchset: https://codereview.chromium.org/2366063002/#ps20001
(title: "Make test more robust")

[commit-bot: I haz the power, 2016-09-23 22:56:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[adamk, 2016-09-23 23:03:38]

https://codereview.chromium.org/2366063002/diff/1/test/mjsunit/modules-skip-c...
File test/mjsunit/modules-skip-circular-valid.js (right):

https://codereview.chromium.org/2366063002/diff/1/test/mjsunit/modules-skip-c...
test/mjsunit/modules-skip-circular-valid.js:7: assertSame(a, b);
On 2016/09/23 22:52:49, neis wrote:
> Can you add assertEquals({}, a) as well? THanks.

Done.

[commit-bot: I haz the power, 2016-09-23 23:46:03]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-23 23:46:20]

Description was changed from

==========
[modules] Initialize requested_modules before recursing in Module::Instantiate

Also fix recursive call to avoid going back through the API.

R=neis@chromium.org
BUG=v8:1569
==========

to

==========
[modules] Initialize requested_modules before recursing in Module::Instantiate

Also fix recursive call to avoid going back through the API.

R=neis@chromium.org
BUG=v8:1569

Committed: https://crrev.com/756f669003356ce909b91923dee93d8dfd692b67
Cr-Commit-Position: refs/heads/master@{#39696}
==========

[commit-bot: I haz the power, 2016-09-23 23:46:21]

Patchset 2 (id:??) landed as
https://crrev.com/756f669003356ce909b91923dee93d8dfd692b67
Cr-Commit-Position: refs/heads/master@{#39696}