[modules] Initialize requested_modules before recursing in Module::Instantiate

src/api.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/api.h"
 
 #include <string.h>  // For memcpy, strlen.
 #ifdef V8_USE_ADDRESS_SANITIZER
 #include <sanitizer/asan_interface.h>
 #endif  // V8_USE_ADDRESS_SANITIZER
@@ skipping 1958 matching lines @@
     // persist a module_map across multiple top-level module loads, as
     // the current module is left in a "half-instantiated" state.
     if (!callback(v8_context, v8_module->GetModuleRequest(i), v8_module,
                   callback_data)
              .ToLocal(&requested_module)) {
       // TODO(adamk): Give this a better error message. But this is a
       // misuse of the API anyway.
       isolate->ThrowIllegalOperation();
       return false;
     }
-    if (!requested_module->Instantiate(v8_context, callback, callback_data)) {
+    module->requested_modules()->set(i, *Utils::OpenHandle(*requested_module));
+    if (!InstantiateModule(requested_module, v8_context, callback,
+                           callback_data)) {
       return false;
     }
-    module->requested_modules()->set(i, *Utils::OpenHandle(*requested_module));
   }
 
   // Resolve imports.
   for (int i = 0, n = regular_imports->length(); i < n; ++i) {
     i::Handle<i::ModuleInfoEntry> entry(
         i::ModuleInfoEntry::cast(regular_imports->get(i)), isolate);
     i::Handle<i::String> name(i::String::cast(entry->import_name()), isolate);
     int module_request = i::Smi::cast(entry->module_request())->value();
     if (i::Module::ResolveImport(module, name, module_request).is_null()) {
       return false;
@@ skipping 7489 matching lines @@
   Address callback_address =
       reinterpret_cast<Address>(reinterpret_cast<intptr_t>(callback));
   VMState<EXTERNAL> state(isolate);
   ExternalCallbackScope call_scope(isolate, callback_address);
   callback(info);
 }
 
 
 }  // namespace internal
 }  // namespace v8