Add WebViewDatabaseAdapter#{get,set}HttpAuthUsernamePassword

android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java

Index: android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java
diff --git a/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java b/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java
index 4a3892673442c2b9ec08979ddb21ba8d4649b45a..a697225e06823acc7b38c0ede8b7c7c10f9eb9fe 100644
--- a/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java
+++ b/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java
@@ -364,6 +364,7 @@ class WebViewChromium implements WebViewProvider, WebViewProvider.ScrollDelegate
     @Override
     public void setHttpAuthUsernamePassword(
             final String host, final String realm, final String username, final String password) {
+        if (mAppTargetSdkVersion > Build.VERSION_CODES.N) return;

[Nate Fischer, 2016/09/26 20:29:37]

I've implemented the no-op for O+ here. Please tell me if this is a mistake and
I should change the approach.

         if (checkNeedsPost()) {
             mFactory.addTask(new Runnable() {
                 @Override
@@ -373,12 +374,14 @@ class WebViewChromium implements WebViewProvider, WebViewProvider.ScrollDelegate
             });
             return;
         }
-        mAwContents.setHttpAuthUsernamePassword(host, realm, username, password);
+        ((WebViewDatabaseAdapter) mFactory.getWebViewDatabase(mContext))
+                .setHttpAuthUsernamePassword(host, realm, username, password);
     }
 
     @Override
     public String[] getHttpAuthUsernamePassword(final String host, final String realm) {
         mFactory.startYourEngines(true);
+        if (mAppTargetSdkVersion > Build.VERSION_CODES.N) return null;

[Nate Fischer, 2016/09/26 20:29:37]

Let me know if the no-op should return a non-null value (either here, or
somewhere else), since this would likely crash the user app at runtime.

         if (checkNeedsPost()) {
             String[] ret = mFactory.runOnUiThreadBlocking(new Callable<String[]>() {
                 @Override
@@ -388,7 +391,8 @@ class WebViewChromium implements WebViewProvider, WebViewProvider.ScrollDelegate
             });
             return ret;
         }
-        return mAwContents.getHttpAuthUsernamePassword(host, realm);
+        return ((WebViewDatabaseAdapter) mFactory.getWebViewDatabase(mContext))
+                .getHttpAuthUsernamePassword(host, realm);
     }
 
     @Override