Add WebViewDatabaseAdapter#{get,set}HttpAuthUsernamePassword

android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package com.android.webview.chromium;
 
 import android.annotation.SuppressLint;
 import android.annotation.TargetApi;
 import android.content.Context;
 import android.content.Intent;
@@ skipping 346 matching lines @@
     }
 
     @Override
     public void savePassword(String host, String username, String password) {
         // This is a deprecated API: intentional no-op.
     }
 
     @Override
     public void setHttpAuthUsernamePassword(
             final String host, final String realm, final String username, final String password) {
+        if (mAppTargetSdkVersion > Build.VERSION_CODES.N) return;

[Nate Fischer, 2016/09/26 20:29:37]

I've implemented the no-op for O+ here. Please tell me if this is a mistake and
I should change the approach.

         if (checkNeedsPost()) {
             mFactory.addTask(new Runnable() {
                 @Override
                 public void run() {
                     setHttpAuthUsernamePassword(host, realm, username, password);
                 }
             });
             return;
         }
-        mAwContents.setHttpAuthUsernamePassword(host, realm, username, password);
+        ((WebViewDatabaseAdapter) mFactory.getWebViewDatabase(mContext))
+                .setHttpAuthUsernamePassword(host, realm, username, password);
     }
 
     @Override
     public String[] getHttpAuthUsernamePassword(final String host, final String realm) {
         mFactory.startYourEngines(true);
+        if (mAppTargetSdkVersion > Build.VERSION_CODES.N) return null;

[Nate Fischer, 2016/09/26 20:29:37]

Let me know if the no-op should return a non-null value (either here, or
somewhere else), since this would likely crash the user app at runtime.

         if (checkNeedsPost()) {
             String[] ret = mFactory.runOnUiThreadBlocking(new Callable<String[]>() {
                 @Override
                 public String[] call() {
                     return getHttpAuthUsernamePassword(host, realm);
                 }
             });
             return ret;
         }
-        return mAwContents.getHttpAuthUsernamePassword(host, realm);
+        return ((WebViewDatabaseAdapter) mFactory.getWebViewDatabase(mContext))
+                .getHttpAuthUsernamePassword(host, realm);
     }
 
     @Override
     public void destroy() {
         if (checkNeedsPost()) {
             mFactory.addTask(new Runnable() {
                 @Override
                 public void run() {
                     destroy();
                 }
@@ skipping 1860 matching lines @@
         mAwContents.extractSmartClipData(x, y, width, height);
     }
 
     // Implements SmartClipProvider
     @Override
     public void setSmartClipResultHandler(final Handler resultHandler) {
         checkThread();
         mAwContents.setSmartClipResultHandler(resultHandler);
     }
 }