Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2365973003: Hide top controls when in VR mode. (Closed)

Created:
4 years, 2 months ago by Ted C
Modified:
4 years, 2 months ago
Reviewers:
mthiesse
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Hide top controls when in VR mode. BUG=643449 Committed: https://crrev.com/3f6f0f0ba68f2990dd3ada929c0d3454e6fbc100 Cr-Commit-Position: refs/heads/master@{#422946}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase and removed unneeded line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -5 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java View 1 5 chunks +42 lines, -5 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
mthiesse
lgtm % comment https://codereview.chromium.org/2365973003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java File chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java (right): https://codereview.chromium.org/2365973003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java#newcode1655 chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java:1655: } You'll need to rebase and ...
4 years, 2 months ago (2016-10-04 18:41:51 UTC) #2
Ted C
https://codereview.chromium.org/2365973003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java File chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java (right): https://codereview.chromium.org/2365973003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java#newcode1655 chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java:1655: } On 2016/10/04 18:41:51, mthiesse wrote: > You'll need ...
4 years, 2 months ago (2016-10-04 20:49:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2365973003/20001
4 years, 2 months ago (2016-10-04 20:50:41 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-04 21:45:29 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 21:49:06 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/3f6f0f0ba68f2990dd3ada929c0d3454e6fbc100
Cr-Commit-Position: refs/heads/master@{#422946}

Powered by Google App Engine
This is Rietveld 408576698