Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4793)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

Issue 2365973003: Hide top controls when in VR mode. (Closed)
Patch Set: Rebase and removed unneeded line Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
index ab9d2b22fc91099424e315347926457ac53e6d54..731e6946e1f1f7e470057ffbf59a9d9216c240dc 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
@@ -81,6 +81,8 @@ import org.chromium.chrome.browser.preferences.datareduction.DataReductionPromoS
import org.chromium.chrome.browser.signin.SigninPromoUtil;
import org.chromium.chrome.browser.snackbar.undo.UndoBarController;
import org.chromium.chrome.browser.tab.Tab;
+import org.chromium.chrome.browser.tab.TabDelegateFactory;
+import org.chromium.chrome.browser.tab.TopControlsVisibilityDelegate;
import org.chromium.chrome.browser.tabmodel.ChromeTabCreator;
import org.chromium.chrome.browser.tabmodel.EmptyTabModelObserver;
import org.chromium.chrome.browser.tabmodel.TabModel;
@@ -103,6 +105,7 @@ import org.chromium.content.common.ContentSwitches;
import org.chromium.content_public.browser.LoadUrlParams;
import org.chromium.ui.base.DeviceFormFactor;
import org.chromium.ui.base.PageTransition;
+import org.chromium.ui.base.WindowAndroid;
import org.chromium.ui.widget.Toast;
import java.lang.annotation.Retention;
@@ -234,6 +237,43 @@ public class ChromeTabbedActivity extends ChromeActivity implements OverviewMode
}
}
+ private class TabbedModeTopControlsVisibilityDelegate extends TopControlsVisibilityDelegate {
+ public TabbedModeTopControlsVisibilityDelegate(Tab tab) {
+ super(tab);
+ }
+
+ @Override
+ public boolean isShowingTopControlsEnabled() {
+ if (mVrShellDelegate.isInVR()) return false;
+ return super.isShowingTopControlsEnabled();
+ }
+
+ @Override
+ public boolean isHidingTopControlsEnabled() {
+ if (mVrShellDelegate.isInVR()) return true;
+ return super.isHidingTopControlsEnabled();
+ }
+ }
+
+ private class TabbedModeTabDelegateFactory extends TabDelegateFactory {
+ @Override
+ public TopControlsVisibilityDelegate createTopControlsVisibilityDelegate(Tab tab) {
+ return new TabbedModeTopControlsVisibilityDelegate(tab);
+ }
+ }
+
+ private class TabbedModeTabCreator extends ChromeTabCreator {
+ public TabbedModeTabCreator(ChromeActivity activity, WindowAndroid nativeWindow,
+ boolean incognito) {
+ super(activity, nativeWindow, incognito);
+ }
+
+ @Override
+ public TabDelegateFactory createDefaultTabDelegateFactory() {
+ return new TabbedModeTabDelegateFactory();
+ }
+ }
+
@Override
public void initializeCompositor() {
try {
@@ -993,8 +1033,8 @@ public class ChromeTabbedActivity extends ChromeActivity implements OverviewMode
return;
}
setTabCreators(
- new ChromeTabCreator(this, getWindowAndroid(), false),
- new ChromeTabCreator(this, getWindowAndroid(), true));
+ new TabbedModeTabCreator(this, getWindowAndroid(), false),
+ new TabbedModeTabCreator(this, getWindowAndroid(), true));
mTabModelSelectorTabObserver = new TabModelSelectorTabObserver(mTabModelSelectorImpl) {
private boolean mIsFirstPageLoadStart = true;
@@ -1563,9 +1603,6 @@ public class ChromeTabbedActivity extends ChromeActivity implements OverviewMode
mControlContainer.setVisibility(visibility);
getCompositorViewHolder().getSurfaceView().setVisibility(visibility);
getCompositorViewHolder().setVisibility(visibility);
-
- // Enter HTML5 fullscreen to ensure the texture fills the entire composited surface.
- getFullscreenManager().setPersistentFullscreenMode(visibility == View.GONE);
}
/**
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698