Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2365903004:
Don't send Quirks Server requests for product_id = 0 (Closed)
|
Created:
4 years, 3 months ago by Greg Levin Modified:
4 years, 2 months ago Reviewers:
oshima CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDon't send Quirks Server requests for product_id = 0
BUG=648711
TEST= ??? You'd have to check VLOGs for a device which can't read its
id from its EDID, but we don't know which devices those are.
We're seeing a lot of requests for id = 0. These are presumably
devices where the manufacturer id and product code (which we roll into
the display product id) couldn't be determined from the EDID. 0 is
a clearly invalid id, so there's no point in sending those requests
to the server.
Committed: https://crrev.com/8a081d1219512f55b1adc2636150a6d37b691bb9
Cr-Commit-Position: refs/heads/master@{#422158}
Patch Set 1 #Patch Set 2 : Fix ash unit test #
Messages
Total messages: 22 (13 generated)
glevin@chromium.org changed reviewers: + oshima@chromium.org
Please have a look!
lgtm
forgot to mention. please update the description "id = 0" -> "product_id = 0".
Description was changed from ========== Don't send Quirks Server requests for id = 0 BUG=648711 TEST= ??? You'd have to check VLOGs for a device which can't read its id from its EDID, but we don't know which devices those are. We're seeing a lot of requests for id = 0. These are presumably devices where the manufacturer id and product code (which we roll into the display product id) couldn't be determined from the EDID. 0 is a clearly invalid id, so there's no point in sending those requests to the server. ========== to ========== Don't send Quirks Server requests for id = 0 BUG=648711 TEST= ??? You'd have to check VLOGs for a device which can't read its id from its EDID, but we don't know which devices those are. We're seeing a lot of requests for id = 0. These are presumably devices where the manufacturer id and product code (which we roll into the display product id) couldn't be determined from the EDID. 0 is a clearly invalid id, so there's no point in sending those requests to the server. ==========
Description was changed from ========== Don't send Quirks Server requests for id = 0 BUG=648711 TEST= ??? You'd have to check VLOGs for a device which can't read its id from its EDID, but we don't know which devices those are. We're seeing a lot of requests for id = 0. These are presumably devices where the manufacturer id and product code (which we roll into the display product id) couldn't be determined from the EDID. 0 is a clearly invalid id, so there's no point in sending those requests to the server. ========== to ========== Don't send Quirks Server requests for product_id = 0 BUG=648711 TEST= ??? You'd have to check VLOGs for a device which can't read its id from its EDID, but we don't know which devices those are. We're seeing a lot of requests for id = 0. These are presumably devices where the manufacturer id and product code (which we roll into the display product id) couldn't be determined from the EDID. 0 is a clearly invalid id, so there's no point in sending those requests to the server. ==========
The CQ bit was checked by glevin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by glevin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
oshima@ - I fixed a failing unit test. The problem and fix were simple... when product_id = 0, there's no thread switching, and no need for the wait loop, so I removed the wait loop call in the one test with id 0. Have another look if you have time, but it's a simple change, and I'll just commit it around end of day if I don't hear otherwise.
The CQ bit was checked by glevin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org Link to the patchset: https://codereview.chromium.org/2365903004/#ps20001 (title: "Fix ash unit test")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Don't send Quirks Server requests for product_id = 0 BUG=648711 TEST= ??? You'd have to check VLOGs for a device which can't read its id from its EDID, but we don't know which devices those are. We're seeing a lot of requests for id = 0. These are presumably devices where the manufacturer id and product code (which we roll into the display product id) couldn't be determined from the EDID. 0 is a clearly invalid id, so there's no point in sending those requests to the server. ========== to ========== Don't send Quirks Server requests for product_id = 0 BUG=648711 TEST= ??? You'd have to check VLOGs for a device which can't read its id from its EDID, but we don't know which devices those are. We're seeing a lot of requests for id = 0. These are presumably devices where the manufacturer id and product code (which we roll into the display product id) couldn't be determined from the EDID. 0 is a clearly invalid id, so there's no point in sending those requests to the server. ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Don't send Quirks Server requests for product_id = 0 BUG=648711 TEST= ??? You'd have to check VLOGs for a device which can't read its id from its EDID, but we don't know which devices those are. We're seeing a lot of requests for id = 0. These are presumably devices where the manufacturer id and product code (which we roll into the display product id) couldn't be determined from the EDID. 0 is a clearly invalid id, so there's no point in sending those requests to the server. ========== to ========== Don't send Quirks Server requests for product_id = 0 BUG=648711 TEST= ??? You'd have to check VLOGs for a device which can't read its id from its EDID, but we don't know which devices those are. We're seeing a lot of requests for id = 0. These are presumably devices where the manufacturer id and product code (which we roll into the display product id) couldn't be determined from the EDID. 0 is a clearly invalid id, so there's no point in sending those requests to the server. Committed: https://crrev.com/8a081d1219512f55b1adc2636150a6d37b691bb9 Cr-Commit-Position: refs/heads/master@{#422158} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/8a081d1219512f55b1adc2636150a6d37b691bb9 Cr-Commit-Position: refs/heads/master@{#422158} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
