Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6174)

Unified Diff: ash/display/display_color_manager_chromeos_unittest.cc

Issue 2365903004: Don't send Quirks Server requests for product_id = 0 (Closed)
Patch Set: Fix ash unit test Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/quirks/quirks_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/display/display_color_manager_chromeos_unittest.cc
diff --git a/ash/display/display_color_manager_chromeos_unittest.cc b/ash/display/display_color_manager_chromeos_unittest.cc
index 36314933729ee3748dc38f1b8b6381b04b1a1263..86a84971f5dbcc398fe0a6f51d97e4c9a5ff0627 100644
--- a/ash/display/display_color_manager_chromeos_unittest.cc
+++ b/ash/display/display_color_manager_chromeos_unittest.cc
@@ -297,7 +297,8 @@ TEST_F(DisplayColorManagerTest, NoMatchProductID) {
EXPECT_TRUE(
base::MatchPattern(log_->GetActionsAndClear(), kResetGammaAction));
- WaitOnColorCalibration();
+ // NOTE: If product_id == 0, there is no thread switching in Quirks or Display
+ // code, so we shouldn't call WaitOnColorCalibration().
EXPECT_STREQ("", log_->GetActionsAndClear().c_str());
}
« no previous file with comments | « no previous file | components/quirks/quirks_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698