Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2365833003: Re-enable rate limiting for Windows Crashpad (Closed)

Created:
4 years, 3 months ago by scottmg
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Re-enable rate limiting for Windows Crashpad Chrome can get itself into crash loops that cause massive numbers of uploads. We'd like to have UMA to see what we're dropping, but for the time being, mitigate by re-instituting the Mac-style 1/hr upload limit. BUG=crashpad:23, 647464 Review-Url: https://codereview.chromium.org/2332103002 Cr-Commit-Position: refs/heads/master@{#418063} (cherry picked from commit d922b3cacfcee6958d71de501a8ced7c25801965) Committed: https://chromium.googlesource.com/chromium/src/+/c1490fd145eda148dd788e554426aa7cb7fde5b2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M components/crash/content/app/crashpad_win.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
scottmg
Committed patchset #1 (id:1) manually as c1490fd145eda148dd788e554426aa7cb7fde5b2.
4 years, 3 months ago (2016-09-23 16:27:55 UTC) #3
scottmg
4 years, 3 months ago (2016-09-23 18:51:41 UTC) #4
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2367723003/ by scottmg@chromium.org.

The reason for reverting is: After further discussion, decided against taking
this in 53.

Powered by Google App Engine
This is Rietveld 408576698