Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2365653002: [Offline pages] Removing RequestQueueStore::UpdateMultipleRequestsCallback (Closed)

Created:
4 years, 3 months ago by fgorski
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline pages] Removing RequestQueueStore::UpdateMultipleRequestsCallback * Removing RequestQueueStore::UpdateMultipleRequestsCallback * Adjusting the signature of ChangeRequestState and it's implementation * Updating tests BUG=645522

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -100 lines) Patch
M components/offline_pages/background/request_queue.cc View 2 chunks +28 lines, -2 lines 0 comments Download
M components/offline_pages/background/request_queue_in_memory_store.h View 1 chunk +3 lines, -4 lines 0 comments Download
M components/offline_pages/background/request_queue_in_memory_store.cc View 1 chunk +9 lines, -13 lines 0 comments Download
M components/offline_pages/background/request_queue_store.h View 2 chunks +1 line, -5 lines 0 comments Download
M components/offline_pages/background/request_queue_store_sql.h View 1 chunk +3 lines, -4 lines 0 comments Download
M components/offline_pages/background/request_queue_store_sql.cc View 6 chunks +68 lines, -52 lines 0 comments Download
M components/offline_pages/background/request_queue_store_unittest.cc View 3 chunks +29 lines, -20 lines 0 comments Download

Depends on Patchset:

Issue 2363563002 Patch 20001

Messages

Total messages: 5 (5 generated)
fgorski
The CQ bit was checked by fgorski@chromium.org to run a CQ dry run
4 years, 3 months ago (2016-09-22 18:02:41 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2365653002/1
4 years, 3 months ago (2016-09-22 18:03:25 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 3 months ago (2016-09-22 18:54:10 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 3 months ago (2016-09-22 18:54:11 UTC) #4
fgorski
4 years, 1 month ago (2016-10-26 21:51:01 UTC) #5 
Description was changed from

==========
[Offline pages] Removing RequestQueueStore::UpdateMultipleRequestsCallback

* Removing RequestQueueStore::UpdateMultipleRequestsCallback
* Adjusting the signature of ChangeRequestState and it's implementation
* Updating tests

BUG=645522
==========

to

==========
[Offline pages] Removing RequestQueueStore::UpdateMultipleRequestsCallback

* Removing RequestQueueStore::UpdateMultipleRequestsCallback
* Adjusting the signature of ChangeRequestState and it's implementation
* Updating tests

BUG=645522
==========

Powered by Google App Engine
This is Rietveld 408576698