Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Side by Side Diff: components/offline_pages/background/request_queue_in_memory_store.cc

Issue 2365653002: [Offline pages] Removing RequestQueueStore::UpdateMultipleRequestsCallback (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/offline_pages/background/request_queue_in_memory_store.h" 5 #include "components/offline_pages/background/request_queue_in_memory_store.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/location.h" 8 #include "base/location.h"
9 #include "base/threading/thread_task_runner_handle.h" 9 #include "base/threading/thread_task_runner_handle.h"
10 #include "components/offline_pages/background/save_page_request.h" 10 #include "components/offline_pages/background/save_page_request.h"
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
92 } 92 }
93 93
94 base::ThreadTaskRunnerHandle::Get()->PostTask( 94 base::ThreadTaskRunnerHandle::Get()->PostTask(
95 FROM_HERE, 95 FROM_HERE,
96 base::Bind(callback, results, base::Passed(std::move(requests)))); 96 base::Bind(callback, results, base::Passed(std::move(requests))));
97 } 97 }
98 98
99 void RequestQueueInMemoryStore::ChangeRequestsState( 99 void RequestQueueInMemoryStore::ChangeRequestsState(
100 const std::vector<int64_t>& request_ids, 100 const std::vector<int64_t>& request_ids,
101 const SavePageRequest::RequestState new_state, 101 const SavePageRequest::RequestState new_state,
102 const UpdateMultipleRequestsCallback& callback) { 102 const UpdateCallback& callback) {
103 RequestQueue::UpdateMultipleRequestResults results; 103 std::unique_ptr<UpdateRequestsResult> result(
104 std::vector<std::unique_ptr<SavePageRequest>> requests; 104 new UpdateRequestsResult(StoreState::LOADED));
105 RequestQueue::UpdateRequestResult result;
106 for (int64_t request_id : request_ids) { 105 for (int64_t request_id : request_ids) {
106 ItemActionStatus status;
107 auto pair = requests_.find(request_id); 107 auto pair = requests_.find(request_id);
108 // If we find this request id, modify it, and return the modified request in 108 // If we find this request id, modify it, and return the modified request in
109 // the request list. 109 // the request list.
110 if (pair != requests_.end()) { 110 if (pair != requests_.end()) {
111 pair->second.set_request_state(new_state); 111 pair->second.set_request_state(new_state);
112 std::unique_ptr<SavePageRequest> request( 112 result->updated_items.push_back(pair->second);
113 new SavePageRequest(pair->second)); 113 status = ItemActionStatus::SUCCESS;
114 requests.push_back(std::move(request));
115 result = RequestQueue::UpdateRequestResult::SUCCESS;
116 } else { 114 } else {
117 result = RequestQueue::UpdateRequestResult::REQUEST_DOES_NOT_EXIST;; 115 status = ItemActionStatus::NOT_FOUND;
118 } 116 }
119 117 result->item_statuses.push_back(std::make_pair(request_id, status));
120 results.push_back(std::make_pair(request_id, result));
121 } 118 }
122 119
123 base::ThreadTaskRunnerHandle::Get()->PostTask( 120 base::ThreadTaskRunnerHandle::Get()->PostTask(
124 FROM_HERE, 121 FROM_HERE, base::Bind(callback, base::Passed(&result)));
125 base::Bind(callback, results, base::Passed(std::move(requests))));
126 } 122 }
127 123
128 void RequestQueueInMemoryStore::Reset(const ResetCallback& callback) { 124 void RequestQueueInMemoryStore::Reset(const ResetCallback& callback) {
129 requests_.clear(); 125 requests_.clear();
130 base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE, 126 base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE,
131 base::Bind(callback, true)); 127 base::Bind(callback, true));
132 } 128 }
133 129
134 } // namespace offline_pages 130 } // namespace offline_pages
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698